diff options
author | Heiko Becker <heirecka@exherbo.org> | 2017-06-02 21:35:37 +0200 |
---|---|---|
committer | Heiko Becker <heirecka@exherbo.org> | 2017-07-29 11:01:28 +0200 |
commit | 51fbcca97ef9058cdb75c52ac77bdc728a296e4a (patch) | |
tree | 982206bd7c35353a10839802d237e53692fe7116 /framework/src/domain/mime | |
parent | ba32e5a606c77b968f53239caf276456c81b4db7 (diff) | |
download | kube-51fbcca97ef9058cdb75c52ac77bdc728a296e4a.tar.gz kube-51fbcca97ef9058cdb75c52ac77bdc728a296e4a.zip |
Use imported targets instead of qt5_use_modules
From Qt's documentation: "This macro is obsolete. Use
target_link_libraries with IMPORTED targets instead." It's only
recommended with cmake >=2.8.9 & < 2.8.12. Kube already requires
cmake 3.0.
One advantage of using the imported targets is, that
cmake complains if a target isn't found before it's used, like
Qt5Concurrent missing from the find_package_call here.
Reviewers: #kube, cmollekopf
Reviewed By: #kube, cmollekopf
Subscribers: #kube
Differential Revision: https://phabricator.kde.org/D6362
Diffstat (limited to 'framework/src/domain/mime')
-rw-r--r-- | framework/src/domain/mime/mimetreeparser/tests/CMakeLists.txt | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/framework/src/domain/mime/mimetreeparser/tests/CMakeLists.txt b/framework/src/domain/mime/mimetreeparser/tests/CMakeLists.txt index 89d97823..015efc32 100644 --- a/framework/src/domain/mime/mimetreeparser/tests/CMakeLists.txt +++ b/framework/src/domain/mime/mimetreeparser/tests/CMakeLists.txt | |||
@@ -10,8 +10,12 @@ include(ECMAddTests) | |||
10 | 10 | ||
11 | add_executable(mimetreeparsertest interfacetest.cpp) | 11 | add_executable(mimetreeparsertest interfacetest.cpp) |
12 | add_gpg_crypto_test(mimetreeparsertest mimetreeparsertest) | 12 | add_gpg_crypto_test(mimetreeparsertest mimetreeparsertest) |
13 | qt5_use_modules(mimetreeparsertest Core Test) | 13 | target_link_libraries(mimetreeparsertest |
14 | target_link_libraries(mimetreeparsertest KF5::Mime kube_otp) | 14 | kube_otp |
15 | Qt5::Core | ||
16 | Qt5::Test | ||
17 | KF5::Mime | ||
18 | ) | ||
15 | 19 | ||
16 | find_package(Gpgmepp 1.7.1 CONFIG) | 20 | find_package(Gpgmepp 1.7.1 CONFIG) |
17 | find_package(QGpgme 1.7.1 CONFIG) | 21 | find_package(QGpgme 1.7.1 CONFIG) |