From 51fbcca97ef9058cdb75c52ac77bdc728a296e4a Mon Sep 17 00:00:00 2001 From: Heiko Becker Date: Fri, 2 Jun 2017 21:35:37 +0200 Subject: Use imported targets instead of qt5_use_modules From Qt's documentation: "This macro is obsolete. Use target_link_libraries with IMPORTED targets instead." It's only recommended with cmake >=2.8.9 & < 2.8.12. Kube already requires cmake 3.0. One advantage of using the imported targets is, that cmake complains if a target isn't found before it's used, like Qt5Concurrent missing from the find_package_call here. Reviewers: #kube, cmollekopf Reviewed By: #kube, cmollekopf Subscribers: #kube Differential Revision: https://phabricator.kde.org/D6362 --- framework/src/domain/mime/mimetreeparser/tests/CMakeLists.txt | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'framework/src/domain/mime') diff --git a/framework/src/domain/mime/mimetreeparser/tests/CMakeLists.txt b/framework/src/domain/mime/mimetreeparser/tests/CMakeLists.txt index 89d97823..015efc32 100644 --- a/framework/src/domain/mime/mimetreeparser/tests/CMakeLists.txt +++ b/framework/src/domain/mime/mimetreeparser/tests/CMakeLists.txt @@ -10,8 +10,12 @@ include(ECMAddTests) add_executable(mimetreeparsertest interfacetest.cpp) add_gpg_crypto_test(mimetreeparsertest mimetreeparsertest) -qt5_use_modules(mimetreeparsertest Core Test) -target_link_libraries(mimetreeparsertest KF5::Mime kube_otp) +target_link_libraries(mimetreeparsertest + kube_otp + Qt5::Core + Qt5::Test + KF5::Mime +) find_package(Gpgmepp 1.7.1 CONFIG) find_package(QGpgme 1.7.1 CONFIG) -- cgit v1.2.3