diff options
-rw-r--r-- | common/genericresource.cpp | 4 | ||||
-rw-r--r-- | common/resource.h | 2 | ||||
-rw-r--r-- | examples/dummyresource/resourcefactory.cpp | 9 | ||||
-rw-r--r-- | examples/dummyresource/resourcefactory.h | 6 | ||||
-rw-r--r-- | synchronizer/listener.cpp | 2 | ||||
-rw-r--r-- | tests/dummyresourcebenchmark.cpp | 26 | ||||
-rw-r--r-- | tests/dummyresourcetest.cpp | 4 |
7 files changed, 26 insertions, 27 deletions
diff --git a/common/genericresource.cpp b/common/genericresource.cpp index b6485d7..139ae98 100644 --- a/common/genericresource.cpp +++ b/common/genericresource.cpp | |||
@@ -155,8 +155,8 @@ private: | |||
155 | 155 | ||
156 | GenericResource::GenericResource(const QByteArray &resourceInstanceIdentifier) | 156 | GenericResource::GenericResource(const QByteArray &resourceInstanceIdentifier) |
157 | : Akonadi2::Resource(), | 157 | : Akonadi2::Resource(), |
158 | mUserQueue(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + "/akonadi2/storage", "org.kde." + resourceInstanceIdentifier + ".userqueue"), | 158 | mUserQueue(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + "/akonadi2/storage", resourceInstanceIdentifier + ".userqueue"), |
159 | mSynchronizerQueue(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + "/akonadi2/storage", "org.kde." + resourceInstanceIdentifier + ".synchronizerqueue"), | 159 | mSynchronizerQueue(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + "/akonadi2/storage", resourceInstanceIdentifier + ".synchronizerqueue"), |
160 | mResourceInstanceIdentifier(resourceInstanceIdentifier), | 160 | mResourceInstanceIdentifier(resourceInstanceIdentifier), |
161 | mError(0) | 161 | mError(0) |
162 | { | 162 | { |
diff --git a/common/resource.h b/common/resource.h index ea1e9d8..ebbc2e1 100644 --- a/common/resource.h +++ b/common/resource.h | |||
@@ -58,7 +58,7 @@ public: | |||
58 | ResourceFactory(QObject *parent); | 58 | ResourceFactory(QObject *parent); |
59 | virtual ~ResourceFactory(); | 59 | virtual ~ResourceFactory(); |
60 | 60 | ||
61 | virtual Resource *createResource() = 0; | 61 | virtual Resource *createResource(const QByteArray &instanceIdentifier) = 0; |
62 | virtual void registerFacades(FacadeFactory &factory) = 0; | 62 | virtual void registerFacades(FacadeFactory &factory) = 0; |
63 | 63 | ||
64 | private: | 64 | private: |
diff --git a/examples/dummyresource/resourcefactory.cpp b/examples/dummyresource/resourcefactory.cpp index e244131..de13aa9 100644 --- a/examples/dummyresource/resourcefactory.cpp +++ b/examples/dummyresource/resourcefactory.cpp | |||
@@ -105,9 +105,8 @@ QMap<QString, QString> populate() | |||
105 | static QMap<QString, QString> s_dataSource = populate(); | 105 | static QMap<QString, QString> s_dataSource = populate(); |
106 | 106 | ||
107 | 107 | ||
108 | //FIXME We need to pass the resource-instance name to generic resource, not the plugin name | 108 | DummyResource::DummyResource(const QByteArray &instanceIdentifier) |
109 | DummyResource::DummyResource() | 109 | : Akonadi2::GenericResource(instanceIdentifier) |
110 | : Akonadi2::GenericResource(PLUGIN_NAME ".instance1") | ||
111 | { | 110 | { |
112 | } | 111 | } |
113 | 112 | ||
@@ -213,9 +212,9 @@ DummyResourceFactory::DummyResourceFactory(QObject *parent) | |||
213 | 212 | ||
214 | } | 213 | } |
215 | 214 | ||
216 | Akonadi2::Resource *DummyResourceFactory::createResource() | 215 | Akonadi2::Resource *DummyResourceFactory::createResource(const QByteArray &instanceIdentifier) |
217 | { | 216 | { |
218 | return new DummyResource(); | 217 | return new DummyResource(instanceIdentifier); |
219 | } | 218 | } |
220 | 219 | ||
221 | void DummyResourceFactory::registerFacades(Akonadi2::FacadeFactory &factory) | 220 | void DummyResourceFactory::registerFacades(Akonadi2::FacadeFactory &factory) |
diff --git a/examples/dummyresource/resourcefactory.h b/examples/dummyresource/resourcefactory.h index f5caf61..f2362bc 100644 --- a/examples/dummyresource/resourcefactory.h +++ b/examples/dummyresource/resourcefactory.h | |||
@@ -32,7 +32,7 @@ | |||
32 | class DummyResource : public Akonadi2::GenericResource | 32 | class DummyResource : public Akonadi2::GenericResource |
33 | { | 33 | { |
34 | public: | 34 | public: |
35 | DummyResource(); | 35 | DummyResource(const QByteArray &instanceIdentifier); |
36 | KAsync::Job<void> synchronizeWithSource(Akonadi2::Pipeline *pipeline) Q_DECL_OVERRIDE; | 36 | KAsync::Job<void> synchronizeWithSource(Akonadi2::Pipeline *pipeline) Q_DECL_OVERRIDE; |
37 | void configurePipeline(Akonadi2::Pipeline *pipeline) Q_DECL_OVERRIDE; | 37 | void configurePipeline(Akonadi2::Pipeline *pipeline) Q_DECL_OVERRIDE; |
38 | }; | 38 | }; |
@@ -46,7 +46,7 @@ class DummyResourceFactory : public Akonadi2::ResourceFactory | |||
46 | public: | 46 | public: |
47 | DummyResourceFactory(QObject *parent = 0); | 47 | DummyResourceFactory(QObject *parent = 0); |
48 | 48 | ||
49 | Akonadi2::Resource *createResource(); | 49 | Akonadi2::Resource *createResource(const QByteArray &instanceIdentifier) Q_DECL_OVERRIDE; |
50 | void registerFacades(Akonadi2::FacadeFactory &factory); | 50 | void registerFacades(Akonadi2::FacadeFactory &factory) Q_DECL_OVERRIDE; |
51 | }; | 51 | }; |
52 | 52 | ||
diff --git a/synchronizer/listener.cpp b/synchronizer/listener.cpp index c8b81e8..36fa6ea 100644 --- a/synchronizer/listener.cpp +++ b/synchronizer/listener.cpp | |||
@@ -370,7 +370,7 @@ void Listener::loadResource() | |||
370 | 370 | ||
371 | Akonadi2::ResourceFactory *resourceFactory = Akonadi2::ResourceFactory::load(m_resourceName); | 371 | Akonadi2::ResourceFactory *resourceFactory = Akonadi2::ResourceFactory::load(m_resourceName); |
372 | if (resourceFactory) { | 372 | if (resourceFactory) { |
373 | m_resource = resourceFactory->createResource(); | 373 | m_resource = resourceFactory->createResource(m_resourceInstanceIdentifier); |
374 | Log() << QString("Resource factory: %1").arg((qlonglong)resourceFactory); | 374 | Log() << QString("Resource factory: %1").arg((qlonglong)resourceFactory); |
375 | Log() << QString("\tResource: %1").arg((qlonglong)m_resource); | 375 | Log() << QString("\tResource: %1").arg((qlonglong)m_resource); |
376 | m_resource->configurePipeline(m_pipeline); | 376 | m_resource->configurePipeline(m_pipeline); |
diff --git a/tests/dummyresourcebenchmark.cpp b/tests/dummyresourcebenchmark.cpp index e350747..fd2cb01 100644 --- a/tests/dummyresourcebenchmark.cpp +++ b/tests/dummyresourcebenchmark.cpp | |||
@@ -29,18 +29,18 @@ private Q_SLOTS: | |||
29 | { | 29 | { |
30 | auto factory = Akonadi2::ResourceFactory::load("org.kde.dummy"); | 30 | auto factory = Akonadi2::ResourceFactory::load("org.kde.dummy"); |
31 | QVERIFY(factory); | 31 | QVERIFY(factory); |
32 | removeFromDisk("org.kde.dummy"); | 32 | removeFromDisk("org.kde.dummy.instance1"); |
33 | removeFromDisk("org.kde.dummy.userqueue"); | 33 | removeFromDisk("org.kde.dummy.instance1.userqueue"); |
34 | removeFromDisk("org.kde.dummy.synchronizerqueue"); | 34 | removeFromDisk("org.kde.dummy.instance1.synchronizerqueue"); |
35 | removeFromDisk("org.kde.dummy.index.uid"); | 35 | removeFromDisk("org.kde.dummy.instance1.index.uid"); |
36 | } | 36 | } |
37 | 37 | ||
38 | void cleanup() | 38 | void cleanup() |
39 | { | 39 | { |
40 | removeFromDisk("org.kde.dummy"); | 40 | removeFromDisk("org.kde.dummy.instance1"); |
41 | removeFromDisk("org.kde.dummy.userqueue"); | 41 | removeFromDisk("org.kde.dummy.instance1.userqueue"); |
42 | removeFromDisk("org.kde.dummy.synchronizerqueue"); | 42 | removeFromDisk("org.kde.dummy.instance1.synchronizerqueue"); |
43 | removeFromDisk("org.kde.dummy.index.uid"); | 43 | removeFromDisk("org.kde.dummy.instance1.index.uid"); |
44 | } | 44 | } |
45 | 45 | ||
46 | void testWriteToFacadeAndQueryByUid() | 46 | void testWriteToFacadeAndQueryByUid() |
@@ -53,14 +53,14 @@ private Q_SLOTS: | |||
53 | event.setProperty("uid", "testuid"); | 53 | event.setProperty("uid", "testuid"); |
54 | QCOMPARE(event.getProperty("uid").toByteArray(), QByteArray("testuid")); | 54 | QCOMPARE(event.getProperty("uid").toByteArray(), QByteArray("testuid")); |
55 | event.setProperty("summary", "summaryValue"); | 55 | event.setProperty("summary", "summaryValue"); |
56 | Akonadi2::Store::create<Akonadi2::ApplicationDomain::Event>(event, "org.kde.dummy"); | 56 | Akonadi2::Store::create<Akonadi2::ApplicationDomain::Event>(event, "org.kde.dummy.instance1"); |
57 | } | 57 | } |
58 | auto appendTime = time.elapsed(); | 58 | auto appendTime = time.elapsed(); |
59 | 59 | ||
60 | //Ensure everything is processed | 60 | //Ensure everything is processed |
61 | { | 61 | { |
62 | Akonadi2::Query query; | 62 | Akonadi2::Query query; |
63 | query.resources << "org.kde.dummy"; | 63 | query.resources << "org.kde.dummy.instance1"; |
64 | query.syncOnDemand = false; | 64 | query.syncOnDemand = false; |
65 | query.processAll = true; | 65 | query.processAll = true; |
66 | 66 | ||
@@ -74,7 +74,7 @@ private Q_SLOTS: | |||
74 | { | 74 | { |
75 | time.start(); | 75 | time.start(); |
76 | Akonadi2::Query query; | 76 | Akonadi2::Query query; |
77 | query.resources << "org.kde.dummy"; | 77 | query.resources << "org.kde.dummy.instance1"; |
78 | query.syncOnDemand = false; | 78 | query.syncOnDemand = false; |
79 | query.processAll = false; | 79 | query.processAll = false; |
80 | 80 | ||
@@ -94,9 +94,9 @@ private Q_SLOTS: | |||
94 | time.start(); | 94 | time.start(); |
95 | int num = 10000; | 95 | int num = 10000; |
96 | 96 | ||
97 | Akonadi2::Pipeline pipeline("org.kde.dummy"); | 97 | Akonadi2::Pipeline pipeline("org.kde.dummy.instance1"); |
98 | QSignalSpy revisionSpy(&pipeline, SIGNAL(revisionUpdated())); | 98 | QSignalSpy revisionSpy(&pipeline, SIGNAL(revisionUpdated())); |
99 | DummyResource resource; | 99 | DummyResource resource("org.kde.dummy.instance1"); |
100 | resource.configurePipeline(&pipeline); | 100 | resource.configurePipeline(&pipeline); |
101 | 101 | ||
102 | flatbuffers::FlatBufferBuilder eventFbb; | 102 | flatbuffers::FlatBufferBuilder eventFbb; |
diff --git a/tests/dummyresourcetest.cpp b/tests/dummyresourcetest.cpp index 4c27b10..1c3b09b 100644 --- a/tests/dummyresourcetest.cpp +++ b/tests/dummyresourcetest.cpp | |||
@@ -85,7 +85,7 @@ private Q_SLOTS: | |||
85 | //Actual test | 85 | //Actual test |
86 | Akonadi2::Pipeline pipeline("org.kde.dummy.instance1"); | 86 | Akonadi2::Pipeline pipeline("org.kde.dummy.instance1"); |
87 | QSignalSpy revisionSpy(&pipeline, SIGNAL(revisionUpdated())); | 87 | QSignalSpy revisionSpy(&pipeline, SIGNAL(revisionUpdated())); |
88 | DummyResource resource; | 88 | DummyResource resource("org.kde.dummy.instance1"); |
89 | resource.configurePipeline(&pipeline); | 89 | resource.configurePipeline(&pipeline); |
90 | resource.processCommand(Akonadi2::Commands::CreateEntityCommand, command, command.size(), &pipeline); | 90 | resource.processCommand(Akonadi2::Commands::CreateEntityCommand, command, command.size(), &pipeline); |
91 | resource.processCommand(Akonadi2::Commands::CreateEntityCommand, command, command.size(), &pipeline); | 91 | resource.processCommand(Akonadi2::Commands::CreateEntityCommand, command, command.size(), &pipeline); |
@@ -178,7 +178,7 @@ private Q_SLOTS: | |||
178 | void testResourceSync() | 178 | void testResourceSync() |
179 | { | 179 | { |
180 | Akonadi2::Pipeline pipeline("org.kde.dummy.instance1"); | 180 | Akonadi2::Pipeline pipeline("org.kde.dummy.instance1"); |
181 | DummyResource resource; | 181 | DummyResource resource("org.kde.dummy.instance1"); |
182 | resource.configurePipeline(&pipeline); | 182 | resource.configurePipeline(&pipeline); |
183 | auto job = resource.synchronizeWithSource(&pipeline); | 183 | auto job = resource.synchronizeWithSource(&pipeline); |
184 | //TODO pass in optional timeout? | 184 | //TODO pass in optional timeout? |