summaryrefslogtreecommitdiffstats
path: root/tests/hawd
diff options
context:
space:
mode:
authorHeiko Becker <heirecka@exherbo.org>2017-05-13 00:11:45 +0200
committerHeiko Becker <heirecka@exherbo.org>2017-07-29 11:00:15 +0200
commit9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df (patch)
tree3a38a173968d2902cbc2459a17126ccb4e4c8cfb /tests/hawd
parent5275b0f173579162176e2340cbb9eaedafe8334a (diff)
downloadsink-9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df.tar.gz
sink-9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df.zip
Use imported targets instead of qt5_use_modules
From Qt's documentation: "This macro is obsolete. Use target_link_libraries with IMPORTED targets instead." It's only recommended with cmake >=2.8.9 & < 2.8.12. Sink already requires cmake 3.0. One advantage of using the imported targets is, that cmake complains if a target isn't found before it's used, like Qt5Concurrent missing from the find_package_call here. Reviewers: #sink, cmollekopf Reviewed By: #sink, cmollekopf Subscribers: #sink Tags: #sink Differential Revision: https://phabricator.kde.org/D6361
Diffstat (limited to 'tests/hawd')
-rw-r--r--tests/hawd/CMakeLists.txt6
1 files changed, 2 insertions, 4 deletions
diff --git a/tests/hawd/CMakeLists.txt b/tests/hawd/CMakeLists.txt
index 6ae5f13..7546920 100644
--- a/tests/hawd/CMakeLists.txt
+++ b/tests/hawd/CMakeLists.txt
@@ -27,8 +27,7 @@ set(SRCS
27 27
28add_library(lib${PROJECT_NAME} SHARED ${lib_SRCS}) 28add_library(lib${PROJECT_NAME} SHARED ${lib_SRCS})
29generate_export_header(lib${PROJECT_NAME} BASE_NAME HAWD EXPORT_FILE_NAME hawd_export.h) 29generate_export_header(lib${PROJECT_NAME} BASE_NAME HAWD EXPORT_FILE_NAME hawd_export.h)
30qt5_use_modules(lib${PROJECT_NAME} Core) 30target_link_libraries(lib${PROJECT_NAME} sink Qt5::Core)
31target_link_libraries(lib${PROJECT_NAME} sink)
32if (LIBGIT2_FOUND) 31if (LIBGIT2_FOUND)
33 target_link_libraries(lib${PROJECT_NAME} ${LIBGIT2_LIBRARIES}) 32 target_link_libraries(lib${PROJECT_NAME} ${LIBGIT2_LIBRARIES})
34endif(LIBGIT2_FOUND) 33endif(LIBGIT2_FOUND)
@@ -36,8 +35,7 @@ endif(LIBGIT2_FOUND)
36install(TARGETS lib${PROJECT_NAME} ${KDE_INSTALL_TARGETS_DEFAULT_ARGS}) 35install(TARGETS lib${PROJECT_NAME} ${KDE_INSTALL_TARGETS_DEFAULT_ARGS})
37 36
38add_executable(${PROJECT_NAME} ${SRCS}) 37add_executable(${PROJECT_NAME} ${SRCS})
39qt5_use_modules(${PROJECT_NAME} Core) 38target_link_libraries(${PROJECT_NAME} lib${PROJECT_NAME} Qt5::Core)
40target_link_libraries(${PROJECT_NAME} lib${PROJECT_NAME})
41if (LIBGIT2_FOUND) 39if (LIBGIT2_FOUND)
42 target_link_libraries(${PROJECT_NAME} ${LIBGIT2_LIBRARIES}) 40 target_link_libraries(${PROJECT_NAME} ${LIBGIT2_LIBRARIES})
43endif(LIBGIT2_FOUND) 41endif(LIBGIT2_FOUND)