summaryrefslogtreecommitdiffstats
path: root/tests/SinkTest.cmake
diff options
context:
space:
mode:
authorHeiko Becker <heirecka@exherbo.org>2017-05-13 00:11:45 +0200
committerHeiko Becker <heirecka@exherbo.org>2017-07-29 11:00:15 +0200
commit9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df (patch)
tree3a38a173968d2902cbc2459a17126ccb4e4c8cfb /tests/SinkTest.cmake
parent5275b0f173579162176e2340cbb9eaedafe8334a (diff)
downloadsink-9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df.tar.gz
sink-9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df.zip
Use imported targets instead of qt5_use_modules
From Qt's documentation: "This macro is obsolete. Use target_link_libraries with IMPORTED targets instead." It's only recommended with cmake >=2.8.9 & < 2.8.12. Sink already requires cmake 3.0. One advantage of using the imported targets is, that cmake complains if a target isn't found before it's used, like Qt5Concurrent missing from the find_package_call here. Reviewers: #sink, cmollekopf Reviewed By: #sink, cmollekopf Subscribers: #sink Tags: #sink Differential Revision: https://phabricator.kde.org/D6361
Diffstat (limited to 'tests/SinkTest.cmake')
-rw-r--r--tests/SinkTest.cmake19
1 files changed, 15 insertions, 4 deletions
diff --git a/tests/SinkTest.cmake b/tests/SinkTest.cmake
index 03076e7..4eb8f43 100644
--- a/tests/SinkTest.cmake
+++ b/tests/SinkTest.cmake
@@ -17,8 +17,13 @@ macro(auto_tests)
17 add_executable(${_testname} ${_testname}.cpp) 17 add_executable(${_testname} ${_testname}.cpp)
18 add_test(${_testname} ${_testname}) 18 add_test(${_testname} ${_testname})
19 add_memcheck_test(${_testname} ${_testname}) 19 add_memcheck_test(${_testname} ${_testname})
20 qt5_use_modules(${_testname} Core Test Concurrent) 20 target_link_libraries(${_testname}
21 target_link_libraries(${_testname} sink libhawd sink_test) 21 sink libhawd
22 sink_test
23 Qt5::Core
24 Qt5::Concurrent
25 Qt5::Test
26 )
22 endforeach(_testname) 27 endforeach(_testname)
23endmacro(auto_tests) 28endmacro(auto_tests)
24 29
@@ -26,7 +31,13 @@ macro(manual_tests)
26 foreach(_testname ${ARGN}) 31 foreach(_testname ${ARGN})
27 add_executable(${_testname} ${_testname}.cpp) 32 add_executable(${_testname} ${_testname}.cpp)
28 add_memcheck_test(${_testname} ${_testname}) 33 add_memcheck_test(${_testname} ${_testname})
29 qt5_use_modules(${_testname} Core Test Concurrent) 34 target_link_libraries(${_testname}
30 target_link_libraries(${_testname} sink libhawd sink_test) 35 sink
36 libhawd
37 sink_test
38 Qt5::Core
39 Qt5::Concurrent
40 Qt5::Test
41 )
31 endforeach(_testname) 42 endforeach(_testname)
32endmacro(manual_tests) 43endmacro(manual_tests)