From 9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df Mon Sep 17 00:00:00 2001 From: Heiko Becker Date: Sat, 13 May 2017 00:11:45 +0200 Subject: Use imported targets instead of qt5_use_modules From Qt's documentation: "This macro is obsolete. Use target_link_libraries with IMPORTED targets instead." It's only recommended with cmake >=2.8.9 & < 2.8.12. Sink already requires cmake 3.0. One advantage of using the imported targets is, that cmake complains if a target isn't found before it's used, like Qt5Concurrent missing from the find_package_call here. Reviewers: #sink, cmollekopf Reviewed By: #sink, cmollekopf Subscribers: #sink Tags: #sink Differential Revision: https://phabricator.kde.org/D6361 --- tests/SinkTest.cmake | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) (limited to 'tests/SinkTest.cmake') diff --git a/tests/SinkTest.cmake b/tests/SinkTest.cmake index 03076e7..4eb8f43 100644 --- a/tests/SinkTest.cmake +++ b/tests/SinkTest.cmake @@ -17,8 +17,13 @@ macro(auto_tests) add_executable(${_testname} ${_testname}.cpp) add_test(${_testname} ${_testname}) add_memcheck_test(${_testname} ${_testname}) - qt5_use_modules(${_testname} Core Test Concurrent) - target_link_libraries(${_testname} sink libhawd sink_test) + target_link_libraries(${_testname} + sink libhawd + sink_test + Qt5::Core + Qt5::Concurrent + Qt5::Test + ) endforeach(_testname) endmacro(auto_tests) @@ -26,7 +31,13 @@ macro(manual_tests) foreach(_testname ${ARGN}) add_executable(${_testname} ${_testname}.cpp) add_memcheck_test(${_testname} ${_testname}) - qt5_use_modules(${_testname} Core Test Concurrent) - target_link_libraries(${_testname} sink libhawd sink_test) + target_link_libraries(${_testname} + sink + libhawd + sink_test + Qt5::Core + Qt5::Concurrent + Qt5::Test + ) endforeach(_testname) endmacro(manual_tests) -- cgit v1.2.3