diff options
author | Heiko Becker <heirecka@exherbo.org> | 2017-05-13 00:11:45 +0200 |
---|---|---|
committer | Heiko Becker <heirecka@exherbo.org> | 2017-07-29 11:00:15 +0200 |
commit | 9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df (patch) | |
tree | 3a38a173968d2902cbc2459a17126ccb4e4c8cfb /synchronizer | |
parent | 5275b0f173579162176e2340cbb9eaedafe8334a (diff) | |
download | sink-9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df.tar.gz sink-9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df.zip |
Use imported targets instead of qt5_use_modules
From Qt's documentation: "This macro is obsolete. Use
target_link_libraries with IMPORTED targets instead." It's only
recommended with cmake >=2.8.9 & < 2.8.12. Sink already requires
cmake 3.0. One advantage of using the imported targets is, that
cmake complains if a target isn't found before it's used, like
Qt5Concurrent missing from the find_package_call here.
Reviewers: #sink, cmollekopf
Reviewed By: #sink, cmollekopf
Subscribers: #sink
Tags: #sink
Differential Revision: https://phabricator.kde.org/D6361
Diffstat (limited to 'synchronizer')
-rw-r--r-- | synchronizer/CMakeLists.txt | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/synchronizer/CMakeLists.txt b/synchronizer/CMakeLists.txt index e049d64..2f8b128 100644 --- a/synchronizer/CMakeLists.txt +++ b/synchronizer/CMakeLists.txt | |||
@@ -7,6 +7,11 @@ set(sinksynchronizer_SRCS | |||
7 | ) | 7 | ) |
8 | 8 | ||
9 | add_executable(${PROJECT_NAME} ${sinksynchronizer_SRCS}) | 9 | add_executable(${PROJECT_NAME} ${sinksynchronizer_SRCS}) |
10 | target_link_libraries(${PROJECT_NAME} sink KAsync ${CMAKE_DL_LIBS}) | 10 | target_link_libraries(${PROJECT_NAME} |
11 | qt5_use_modules(${PROJECT_NAME} Core Network) | 11 | sink |
12 | Qt5::Core | ||
13 | Qt5::Network | ||
14 | KAsync | ||
15 | ${CMAKE_DL_LIBS} | ||
16 | ) | ||
12 | install(TARGETS ${PROJECT_NAME} ${KDE_INSTALL_TARGETS_DEFAULT_ARGS}) | 17 | install(TARGETS ${PROJECT_NAME} ${KDE_INSTALL_TARGETS_DEFAULT_ARGS}) |