From 9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df Mon Sep 17 00:00:00 2001 From: Heiko Becker Date: Sat, 13 May 2017 00:11:45 +0200 Subject: Use imported targets instead of qt5_use_modules From Qt's documentation: "This macro is obsolete. Use target_link_libraries with IMPORTED targets instead." It's only recommended with cmake >=2.8.9 & < 2.8.12. Sink already requires cmake 3.0. One advantage of using the imported targets is, that cmake complains if a target isn't found before it's used, like Qt5Concurrent missing from the find_package_call here. Reviewers: #sink, cmollekopf Reviewed By: #sink, cmollekopf Subscribers: #sink Tags: #sink Differential Revision: https://phabricator.kde.org/D6361 --- synchronizer/CMakeLists.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'synchronizer') diff --git a/synchronizer/CMakeLists.txt b/synchronizer/CMakeLists.txt index e049d64..2f8b128 100644 --- a/synchronizer/CMakeLists.txt +++ b/synchronizer/CMakeLists.txt @@ -7,6 +7,11 @@ set(sinksynchronizer_SRCS ) add_executable(${PROJECT_NAME} ${sinksynchronizer_SRCS}) -target_link_libraries(${PROJECT_NAME} sink KAsync ${CMAKE_DL_LIBS}) -qt5_use_modules(${PROJECT_NAME} Core Network) +target_link_libraries(${PROJECT_NAME} + sink + Qt5::Core + Qt5::Network + KAsync + ${CMAKE_DL_LIBS} +) install(TARGETS ${PROJECT_NAME} ${KDE_INSTALL_TARGETS_DEFAULT_ARGS}) -- cgit v1.2.3