Only count every uid once.

The previous code would fail on the second revision with the same uid.

1 files changed, 13 insertions, 3 deletions

diff --git a/sinksh/syntax_modules/sink_inspect.cpp b/sinksh/syntax_modules/sink_inspect.cpp
index b271b4f..9cc3b23 100644
--- a/sinksh/syntax_modules/sink_inspect.cpp
+++ b/sinksh/syntax_modules/sink_inspect.cpp
@@ -85,10 +85,9 @@ bool inspect(const QStringList &args, State &state)
                 },
                 false);
 
+        QSet<QByteArray> uids;
         db.scan("", [&] (const QByteArray &key, const QByteArray &data) {
-                    if (!hash.remove(Sink::Storage::DataStore::uidFromKey(key))) {
-                        qWarning() << "Failed to find RID for " << key;
-                    }
+                    uids.insert(Sink::Storage::DataStore::uidFromKey(key));
                     return true;
                 },
                 [&](const Sink::Storage::DataStore::Error &e) {
@@ -96,6 +95,17 @@ bool inspect(const QStringList &args, State &state)
                 },
                 false);
 
+        int missing = 0;
+        for (const auto &uid : uids) {
+            if (!hash.remove(uid)) {
+                missing++;
+                qWarning() << "Failed to find RID for " << uid;
+            }
+        }
+        if (missing) {
+            qWarning() << "Found a total of " << missing << " missing rids";
+        }
+
         //If we still have items in the hash it means we have rid mappings for entities
         //that no longer exist.
         if (!hash.isEmpty()) {