diff options
author | Heiko Becker <heirecka@exherbo.org> | 2017-05-13 00:11:45 +0200 |
---|---|---|
committer | Heiko Becker <heirecka@exherbo.org> | 2017-07-29 11:00:15 +0200 |
commit | 9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df (patch) | |
tree | 3a38a173968d2902cbc2459a17126ccb4e4c8cfb /examples/mailtransportresource | |
parent | 5275b0f173579162176e2340cbb9eaedafe8334a (diff) | |
download | sink-9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df.tar.gz sink-9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df.zip |
Use imported targets instead of qt5_use_modules
From Qt's documentation: "This macro is obsolete. Use
target_link_libraries with IMPORTED targets instead." It's only
recommended with cmake >=2.8.9 & < 2.8.12. Sink already requires
cmake 3.0. One advantage of using the imported targets is, that
cmake complains if a target isn't found before it's used, like
Qt5Concurrent missing from the find_package_call here.
Reviewers: #sink, cmollekopf
Reviewed By: #sink, cmollekopf
Subscribers: #sink
Tags: #sink
Differential Revision: https://phabricator.kde.org/D6361
Diffstat (limited to 'examples/mailtransportresource')
-rw-r--r-- | examples/mailtransportresource/CMakeLists.txt | 18 |
1 files changed, 14 insertions, 4 deletions
diff --git a/examples/mailtransportresource/CMakeLists.txt b/examples/mailtransportresource/CMakeLists.txt index 03b89db..1c34676 100644 --- a/examples/mailtransportresource/CMakeLists.txt +++ b/examples/mailtransportresource/CMakeLists.txt | |||
@@ -10,13 +10,23 @@ include_directories(${CURL_INCLUDE_DIRS}) | |||
10 | 10 | ||
11 | 11 | ||
12 | add_library(${PROJECT_NAME} SHARED mailtransportresource.cpp mailtransport.cpp) | 12 | add_library(${PROJECT_NAME} SHARED mailtransportresource.cpp mailtransport.cpp) |
13 | qt5_use_modules(${PROJECT_NAME} Core Network) | 13 | target_link_libraries(${PROJECT_NAME} |
14 | target_link_libraries(${PROJECT_NAME} sink KF5::Mime ${CURL_LIBRARIES}) | 14 | sink |
15 | Qt5::Core | ||
16 | Qt5::Network | ||
17 | KF5::Mime | ||
18 | ${CURL_LIBRARIES} | ||
19 | ) | ||
15 | install(TARGETS ${PROJECT_NAME} LIBRARY DESTINATION ${SINK_RESOURCE_PLUGINS_PATH}) | 20 | install(TARGETS ${PROJECT_NAME} LIBRARY DESTINATION ${SINK_RESOURCE_PLUGINS_PATH}) |
16 | 21 | ||
17 | add_executable(sink_smtp_test smtptest.cpp mailtransport.cpp) | 22 | add_executable(sink_smtp_test smtptest.cpp mailtransport.cpp) |
18 | qt5_use_modules(sink_smtp_test Core Network) | 23 | target_link_libraries(sink_smtp_test |
19 | target_link_libraries(sink_smtp_test sink KF5::Mime ${CURL_LIBRARIES}) | 24 | sink |
25 | Qt5::Core | ||
26 | Qt5::Network | ||
27 | KF5::Mime | ||
28 | ${CURL_LIBRARIES} | ||
29 | ) | ||
20 | install(TARGETS sink_smtp_test ${KDE_INSTALL_TARGETS_DEFAULT_ARGS}) | 30 | install(TARGETS sink_smtp_test ${KDE_INSTALL_TARGETS_DEFAULT_ARGS}) |
21 | 31 | ||
22 | add_subdirectory(tests) | 32 | add_subdirectory(tests) |