diff options
author | Christian Mollekopf <chrigi_1@fastmail.fm> | 2016-10-16 14:55:20 +0200 |
---|---|---|
committer | Christian Mollekopf <chrigi_1@fastmail.fm> | 2016-10-21 09:02:21 +0200 |
commit | 237b9ae4113e7a9f489632296941becb71afdb45 (patch) | |
tree | 01cde58f495944f01cad9d282391d4efd2897141 /examples/dummyresource | |
parent | 95d11bf0be98a4e3c08502fe23417b800233ce14 (diff) | |
download | sink-237b9ae4113e7a9f489632296941becb71afdb45.tar.gz sink-237b9ae4113e7a9f489632296941becb71afdb45.zip |
Refactor how the storage is used.
This is the initial refactoring to improve how we deal with the storage.
It does a couple of things:
* Rename Sink::Storage to Sink::Storage::DataStore to free up the
Sink::Storage namespace
* Introduce a Sink::ResourceContext to have a single object that can be
passed around containing everything that is necessary to operate on a
resource. This is a lot better than the multiple separate parameters
that we used to pass around all over the place, while still allowing
for dependency injection for tests.
* Tie storage access together using the new EntityStore that directly
works with ApplicationDomainTypes. This gives us a central place where
main storage, indexes and buffer adaptors are tied together, which
will also give us a place to implement external indexes, such as a
fulltextindex using xapian.
* Use ApplicationDomainTypes as the default way to pass around entities.
Instead of using various ways to pass around entities (buffers,
buffer adaptors, ApplicationDomainTypes), only use a single way.
The old approach was confusing, and was only done as:
* optimization; really shouldn't be necessary and otherwise I'm sure
we can find better ways to optimize ApplicationDomainType itself.
* a way to account for entities that have multiple buffers, a concept
that I no longer deem relevant.
While this commit does the bulk of the work to get there, the following
commits will refactor more stuff to get things back to normal.
Diffstat (limited to 'examples/dummyresource')
-rw-r--r-- | examples/dummyresource/facade.cpp | 12 | ||||
-rw-r--r-- | examples/dummyresource/facade.h | 6 | ||||
-rw-r--r-- | examples/dummyresource/resourcefactory.cpp | 16 | ||||
-rw-r--r-- | examples/dummyresource/resourcefactory.h | 4 |
4 files changed, 19 insertions, 19 deletions
diff --git a/examples/dummyresource/facade.cpp b/examples/dummyresource/facade.cpp index 120498a..4343eba 100644 --- a/examples/dummyresource/facade.cpp +++ b/examples/dummyresource/facade.cpp | |||
@@ -21,8 +21,8 @@ | |||
21 | 21 | ||
22 | #include "domainadaptor.h" | 22 | #include "domainadaptor.h" |
23 | 23 | ||
24 | DummyResourceFacade::DummyResourceFacade(const QByteArray &instanceIdentifier) | 24 | DummyResourceFacade::DummyResourceFacade(const Sink::ResourceContext &context) |
25 | : Sink::GenericFacade<Sink::ApplicationDomain::Event>(instanceIdentifier, QSharedPointer<DummyEventAdaptorFactory>::create()) | 25 | : Sink::GenericFacade<Sink::ApplicationDomain::Event>(context) |
26 | { | 26 | { |
27 | } | 27 | } |
28 | 28 | ||
@@ -31,8 +31,8 @@ DummyResourceFacade::~DummyResourceFacade() | |||
31 | } | 31 | } |
32 | 32 | ||
33 | 33 | ||
34 | DummyResourceMailFacade::DummyResourceMailFacade(const QByteArray &instanceIdentifier) | 34 | DummyResourceMailFacade::DummyResourceMailFacade(const Sink::ResourceContext &context) |
35 | : Sink::GenericFacade<Sink::ApplicationDomain::Mail>(instanceIdentifier, QSharedPointer<DummyMailAdaptorFactory>::create()) | 35 | : Sink::GenericFacade<Sink::ApplicationDomain::Mail>(context) |
36 | { | 36 | { |
37 | } | 37 | } |
38 | 38 | ||
@@ -41,8 +41,8 @@ DummyResourceMailFacade::~DummyResourceMailFacade() | |||
41 | } | 41 | } |
42 | 42 | ||
43 | 43 | ||
44 | DummyResourceFolderFacade::DummyResourceFolderFacade(const QByteArray &instanceIdentifier) | 44 | DummyResourceFolderFacade::DummyResourceFolderFacade(const Sink::ResourceContext &context) |
45 | : Sink::GenericFacade<Sink::ApplicationDomain::Folder>(instanceIdentifier, QSharedPointer<DummyFolderAdaptorFactory>::create()) | 45 | : Sink::GenericFacade<Sink::ApplicationDomain::Folder>(context) |
46 | { | 46 | { |
47 | } | 47 | } |
48 | 48 | ||
diff --git a/examples/dummyresource/facade.h b/examples/dummyresource/facade.h index 5e0096d..1bb45fd 100644 --- a/examples/dummyresource/facade.h +++ b/examples/dummyresource/facade.h | |||
@@ -25,20 +25,20 @@ | |||
25 | class DummyResourceFacade : public Sink::GenericFacade<Sink::ApplicationDomain::Event> | 25 | class DummyResourceFacade : public Sink::GenericFacade<Sink::ApplicationDomain::Event> |
26 | { | 26 | { |
27 | public: | 27 | public: |
28 | DummyResourceFacade(const QByteArray &instanceIdentifier); | 28 | DummyResourceFacade(const Sink::ResourceContext &context); |
29 | virtual ~DummyResourceFacade(); | 29 | virtual ~DummyResourceFacade(); |
30 | }; | 30 | }; |
31 | 31 | ||
32 | class DummyResourceMailFacade : public Sink::GenericFacade<Sink::ApplicationDomain::Mail> | 32 | class DummyResourceMailFacade : public Sink::GenericFacade<Sink::ApplicationDomain::Mail> |
33 | { | 33 | { |
34 | public: | 34 | public: |
35 | DummyResourceMailFacade(const QByteArray &instanceIdentifier); | 35 | DummyResourceMailFacade(const Sink::ResourceContext &context); |
36 | virtual ~DummyResourceMailFacade(); | 36 | virtual ~DummyResourceMailFacade(); |
37 | }; | 37 | }; |
38 | 38 | ||
39 | class DummyResourceFolderFacade : public Sink::GenericFacade<Sink::ApplicationDomain::Folder> | 39 | class DummyResourceFolderFacade : public Sink::GenericFacade<Sink::ApplicationDomain::Folder> |
40 | { | 40 | { |
41 | public: | 41 | public: |
42 | DummyResourceFolderFacade(const QByteArray &instanceIdentifier); | 42 | DummyResourceFolderFacade(const Sink::ResourceContext &context); |
43 | virtual ~DummyResourceFolderFacade(); | 43 | virtual ~DummyResourceFolderFacade(); |
44 | }; | 44 | }; |
diff --git a/examples/dummyresource/resourcefactory.cpp b/examples/dummyresource/resourcefactory.cpp index 6d14721..e288be2 100644 --- a/examples/dummyresource/resourcefactory.cpp +++ b/examples/dummyresource/resourcefactory.cpp | |||
@@ -53,8 +53,8 @@ SINK_DEBUG_AREA("dummyresource") | |||
53 | class DummySynchronizer : public Sink::Synchronizer { | 53 | class DummySynchronizer : public Sink::Synchronizer { |
54 | public: | 54 | public: |
55 | 55 | ||
56 | DummySynchronizer(const QByteArray &resourceType, const QByteArray &resourceInstanceIdentifier) | 56 | DummySynchronizer(const Sink::ResourceContext &context) |
57 | : Sink::Synchronizer(resourceType, resourceInstanceIdentifier) | 57 | : Sink::Synchronizer(context) |
58 | { | 58 | { |
59 | 59 | ||
60 | } | 60 | } |
@@ -129,11 +129,11 @@ class DummySynchronizer : public Sink::Synchronizer { | |||
129 | 129 | ||
130 | }; | 130 | }; |
131 | 131 | ||
132 | DummyResource::DummyResource(const QByteArray &instanceIdentifier, const QSharedPointer<Sink::Pipeline> &pipeline) | 132 | DummyResource::DummyResource(const Sink::ResourceContext &resourceContext, const QSharedPointer<Sink::Pipeline> &pipeline) |
133 | : Sink::GenericResource(PLUGIN_NAME, instanceIdentifier, pipeline) | 133 | : Sink::GenericResource(resourceContext, pipeline) |
134 | { | 134 | { |
135 | setupSynchronizer(QSharedPointer<DummySynchronizer>::create(PLUGIN_NAME, instanceIdentifier)); | 135 | setupSynchronizer(QSharedPointer<DummySynchronizer>::create(resourceContext)); |
136 | setupChangereplay(QSharedPointer<Sink::NullChangeReplay>::create(instanceIdentifier)); | 136 | setupChangereplay(QSharedPointer<Sink::NullChangeReplay>::create(resourceContext)); |
137 | setupPreprocessors(ENTITY_TYPE_MAIL, | 137 | setupPreprocessors(ENTITY_TYPE_MAIL, |
138 | QVector<Sink::Preprocessor*>() << new MailPropertyExtractor << new DefaultIndexUpdater<Sink::ApplicationDomain::Mail>); | 138 | QVector<Sink::Preprocessor*>() << new MailPropertyExtractor << new DefaultIndexUpdater<Sink::ApplicationDomain::Mail>); |
139 | setupPreprocessors(ENTITY_TYPE_FOLDER, | 139 | setupPreprocessors(ENTITY_TYPE_FOLDER, |
@@ -182,9 +182,9 @@ DummyResourceFactory::DummyResourceFactory(QObject *parent) | |||
182 | 182 | ||
183 | } | 183 | } |
184 | 184 | ||
185 | Sink::Resource *DummyResourceFactory::createResource(const QByteArray &instanceIdentifier) | 185 | Sink::Resource *DummyResourceFactory::createResource(const Sink::ResourceContext &resourceContext) |
186 | { | 186 | { |
187 | return new DummyResource(instanceIdentifier); | 187 | return new DummyResource(resourceContext); |
188 | } | 188 | } |
189 | 189 | ||
190 | void DummyResourceFactory::registerFacades(Sink::FacadeFactory &factory) | 190 | void DummyResourceFactory::registerFacades(Sink::FacadeFactory &factory) |
diff --git a/examples/dummyresource/resourcefactory.h b/examples/dummyresource/resourcefactory.h index 0a29d53..3dd82ff 100644 --- a/examples/dummyresource/resourcefactory.h +++ b/examples/dummyresource/resourcefactory.h | |||
@@ -32,7 +32,7 @@ | |||
32 | class DummyResource : public Sink::GenericResource | 32 | class DummyResource : public Sink::GenericResource |
33 | { | 33 | { |
34 | public: | 34 | public: |
35 | DummyResource(const QByteArray &instanceIdentifier, const QSharedPointer<Sink::Pipeline> &pipeline = QSharedPointer<Sink::Pipeline>()); | 35 | DummyResource(const Sink::ResourceContext &resourceContext, const QSharedPointer<Sink::Pipeline> &pipeline = QSharedPointer<Sink::Pipeline>()); |
36 | virtual ~DummyResource(); | 36 | virtual ~DummyResource(); |
37 | 37 | ||
38 | KAsync::Job<void> synchronizeWithSource() Q_DECL_OVERRIDE; | 38 | KAsync::Job<void> synchronizeWithSource() Q_DECL_OVERRIDE; |
@@ -48,7 +48,7 @@ class DummyResourceFactory : public Sink::ResourceFactory | |||
48 | public: | 48 | public: |
49 | DummyResourceFactory(QObject *parent = 0); | 49 | DummyResourceFactory(QObject *parent = 0); |
50 | 50 | ||
51 | Sink::Resource *createResource(const QByteArray &instanceIdentifier) Q_DECL_OVERRIDE; | 51 | Sink::Resource *createResource(const Sink::ResourceContext &resourceContext) Q_DECL_OVERRIDE; |
52 | void registerFacades(Sink::FacadeFactory &factory) Q_DECL_OVERRIDE; | 52 | void registerFacades(Sink::FacadeFactory &factory) Q_DECL_OVERRIDE; |
53 | void registerAdaptorFactories(Sink::AdaptorFactoryRegistry ®istry) Q_DECL_OVERRIDE; | 53 | void registerAdaptorFactories(Sink::AdaptorFactoryRegistry ®istry) Q_DECL_OVERRIDE; |
54 | void removeDataFromDisk(const QByteArray &instanceIdentifier) Q_DECL_OVERRIDE; | 54 | void removeDataFromDisk(const QByteArray &instanceIdentifier) Q_DECL_OVERRIDE; |