diff options
| author | Heiko Becker <heirecka@exherbo.org> | 2017-05-13 00:11:45 +0200 |
|---|---|---|
| committer | Heiko Becker <heirecka@exherbo.org> | 2017-07-29 11:00:15 +0200 |
| commit | 9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df (patch) | |
| tree | 3a38a173968d2902cbc2459a17126ccb4e4c8cfb /examples/davresource | |
| parent | 5275b0f173579162176e2340cbb9eaedafe8334a (diff) | |
| download | sink-9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df.tar.gz sink-9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df.zip | |
Use imported targets instead of qt5_use_modules
From Qt's documentation: "This macro is obsolete. Use
target_link_libraries with IMPORTED targets instead." It's only
recommended with cmake >=2.8.9 & < 2.8.12. Sink already requires
cmake 3.0. One advantage of using the imported targets is, that
cmake complains if a target isn't found before it's used, like
Qt5Concurrent missing from the find_package_call here.
Reviewers: #sink, cmollekopf
Reviewed By: #sink, cmollekopf
Subscribers: #sink
Tags: #sink
Differential Revision: https://phabricator.kde.org/D6361
Diffstat (limited to 'examples/davresource')
| -rw-r--r-- | examples/davresource/CMakeLists.txt | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/examples/davresource/CMakeLists.txt b/examples/davresource/CMakeLists.txt index 7091edc..2351ecd 100644 --- a/examples/davresource/CMakeLists.txt +++ b/examples/davresource/CMakeLists.txt | |||
| @@ -6,7 +6,6 @@ include_directories(${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR}) | |||
| 6 | find_package(KPimKDAV2 REQUIRED) | 6 | find_package(KPimKDAV2 REQUIRED) |
| 7 | 7 | ||
| 8 | add_library(${PROJECT_NAME} SHARED davresource.cpp) | 8 | add_library(${PROJECT_NAME} SHARED davresource.cpp) |
| 9 | qt5_use_modules(${PROJECT_NAME} Core Network) | 9 | target_link_libraries(${PROJECT_NAME} sink Qt5::Core Qt5::Network KPim::KDAV2) |
| 10 | target_link_libraries(${PROJECT_NAME} sink KPim::KDAV2) | ||
| 11 | 10 | ||
| 12 | install(TARGETS ${PROJECT_NAME} LIBRARY DESTINATION ${SINK_RESOURCE_PLUGINS_PATH}) | 11 | install(TARGETS ${PROJECT_NAME} LIBRARY DESTINATION ${SINK_RESOURCE_PLUGINS_PATH}) |