Removed ResourceAccess::Private leak and resolved resulting memory

corruption.

It looks like the memory corruption (malloc started to crash) was coming QLocalSocket related
signals. According to the docs it's not safe (whatever that means), to
delete a QObject with pending signals, so we use deleteLater to schedule
it's deletion. This resolved the crashes.

1 files changed, 5 insertions, 1 deletions

diff --git a/common/resourceaccess.h b/common/resourceaccess.h
index 7df6a1b..9387e99 100644
--- a/common/resourceaccess.h
+++ b/common/resourceaccess.h
@@ -44,6 +44,7 @@ public:
     typedef QSharedPointer<ResourceAccessInterface> Ptr;
 
     ResourceAccessInterface()
+        : QObject()
     {
     }
     virtual ~ResourceAccessInterface()
@@ -110,7 +111,7 @@ public:
     typedef QSharedPointer<ResourceAccess> Ptr;
 
     ResourceAccess(const QByteArray &resourceInstanceIdentifier, const QByteArray &resourceType);
-    ~ResourceAccess();
+    virtual ~ResourceAccess();
 
     QByteArray resourceName() const;
     bool isReady() const;
@@ -167,6 +168,9 @@ public:
     static ResourceAccessFactory &instance();
     Sink::ResourceAccess::Ptr getAccess(const QByteArray &instanceIdentifier, const QByteArray resourceType);
 
+private:
+    ResourceAccessFactory();
+
     QHash<QByteArray, QWeakPointer<Sink::ResourceAccess>> mWeakCache;
     QHash<QByteArray, Sink::ResourceAccess::Ptr> mCache;
     QHash<QByteArray, QSharedPointer<QTimer>> mTimer;