Fixed Async::Future.

The future is copied an the finished boolean has to be in the shared part,
otherwise the original copy never receives the updated value.

1 files changed, 9 insertions, 4 deletions

diff --git a/async/src/future.h b/async/src/future.h
index aa8e9be..54580ad 100644
--- a/async/src/future.h
+++ b/async/src/future.h
@@ -35,13 +35,11 @@ public:
     virtual ~FutureBase();
 
     virtual void setFinished() = 0;
-    bool isFinished() const;
+    virtual bool isFinished() const = 0;
 
 protected:
     FutureBase();
     FutureBase(const FutureBase &other);
-
-    bool mFinished;
 };
 
 template<typename T>
@@ -58,7 +56,7 @@ class FutureGeneric : public FutureBase
 public:
     void setFinished()
     {
-        mFinished = true;
+        d->finished = true;
         for (auto watcher : d->watchers) {
             if (watcher) {
                 watcher->futureReadyCallback();
@@ -66,6 +64,11 @@ public:
         }
     }
 
+    bool isFinished() const
+    {
+        return d->finished;
+    }
+
     void waitForFinished()
     {
         if (isFinished()) {
@@ -93,10 +96,12 @@ protected:
     class Private : public QSharedData
     {
     public:
+        Private() : QSharedData(), finished(false) {}
         typename std::conditional<std::is_void<T>::value, int /* dummy */, T>::type
         value;
 
         QVector<QPointer<FutureWatcher<T>>> watchers;
+        bool finished;
     };
 
     QExplicitlySharedDataPointer<Private> d;