diff options
-rw-r--r-- | framework/src/domain/mime/mimetreeparser/messagepart.cpp | 18 | ||||
-rw-r--r-- | framework/src/domain/mime/mimetreeparser/partmetadata.h | 2 |
2 files changed, 5 insertions, 15 deletions
diff --git a/framework/src/domain/mime/mimetreeparser/messagepart.cpp b/framework/src/domain/mime/mimetreeparser/messagepart.cpp index 89e71a68..26382360 100644 --- a/framework/src/domain/mime/mimetreeparser/messagepart.cpp +++ b/framework/src/domain/mime/mimetreeparser/messagepart.cpp | |||
@@ -857,17 +857,14 @@ void SignedMessagePart::startVerificationDetached(const QByteArray &text, KMime: | |||
857 | mMetaData.status = tr("Wrong Crypto Plug-In."); | 857 | mMetaData.status = tr("Wrong Crypto Plug-In."); |
858 | mMetaData.status_code = GPGME_SIG_STAT_NONE; | 858 | mMetaData.status_code = GPGME_SIG_STAT_NONE; |
859 | 859 | ||
860 | CryptoBodyPartMemento *m = verifySignature(text, signature); | 860 | if (auto *m = verifySignature(text, signature)) { |
861 | m->exec(); | 861 | m->exec(); |
862 | |||
863 | if (m && !mMetaData.inProgress) { | ||
864 | if (!signature.isEmpty()) { | 862 | if (!signature.isEmpty()) { |
865 | mVerifiedText = text; | 863 | mVerifiedText = text; |
866 | } | 864 | } |
867 | setVerificationResult(m, textNode); | 865 | setVerificationResult(m, textNode); |
868 | } | 866 | delete m; |
869 | 867 | } else { | |
870 | if (!m && !mMetaData.inProgress) { | ||
871 | QString errorMsg; | 868 | QString errorMsg; |
872 | QString cryptPlugLibName; | 869 | QString cryptPlugLibName; |
873 | QString cryptPlugDisplayName; | 870 | QString cryptPlugDisplayName; |
@@ -893,7 +890,6 @@ void SignedMessagePart::startVerificationDetached(const QByteArray &text, KMime: | |||
893 | "verified.<br />" | 890 | "verified.<br />" |
894 | "Reason: %1").arg(errorMsg); | 891 | "Reason: %1").arg(errorMsg); |
895 | } | 892 | } |
896 | delete m; | ||
897 | 893 | ||
898 | if (!mMetaData.isSigned) { | 894 | if (!mMetaData.isSigned) { |
899 | mMetaData.creationTime = QDateTime(); | 895 | mMetaData.creationTime = QDateTime(); |
@@ -1004,7 +1000,7 @@ void EncryptedMessagePart::startDecryption(const QByteArray &text, const QTextCo | |||
1004 | 1000 | ||
1005 | startDecryption(content); | 1001 | startDecryption(content); |
1006 | 1002 | ||
1007 | if (!mMetaData.inProgress && mMetaData.isDecryptable) { | 1003 | if (mMetaData.isDecryptable) { |
1008 | const auto codec = aCodec ? aCodec : mOtp->codecFor(mNode); | 1004 | const auto codec = aCodec ? aCodec : mOtp->codecFor(mNode); |
1009 | const auto decoded = codec->toUnicode(mDecryptedData); | 1005 | const auto decoded = codec->toUnicode(mDecryptedData); |
1010 | if (hasSubParts()) { | 1006 | if (hasSubParts()) { |
@@ -1025,7 +1021,6 @@ bool EncryptedMessagePart::okDecryptMIME(KMime::Content &data) | |||
1025 | mError = NoError; | 1021 | mError = NoError; |
1026 | auto passphraseError = false; | 1022 | auto passphraseError = false; |
1027 | auto noSecKey = false; | 1023 | auto noSecKey = false; |
1028 | mMetaData.inProgress = false; | ||
1029 | mMetaData.errorText.clear(); | 1024 | mMetaData.errorText.clear(); |
1030 | mMetaData.auditLogError = GpgME::Error(); | 1025 | mMetaData.auditLogError = GpgME::Error(); |
1031 | mMetaData.auditLog.clear(); | 1026 | mMetaData.auditLog.clear(); |
@@ -1122,9 +1117,6 @@ void EncryptedMessagePart::startDecryption(KMime::Content *data) | |||
1122 | 1117 | ||
1123 | bool bOkDecrypt = okDecryptMIME(*data); | 1118 | bool bOkDecrypt = okDecryptMIME(*data); |
1124 | 1119 | ||
1125 | if (mMetaData.inProgress) { | ||
1126 | return; | ||
1127 | } | ||
1128 | mMetaData.isDecryptable = bOkDecrypt; | 1120 | mMetaData.isDecryptable = bOkDecrypt; |
1129 | 1121 | ||
1130 | if (!mMetaData.isDecryptable) { | 1122 | if (!mMetaData.isDecryptable) { |
diff --git a/framework/src/domain/mime/mimetreeparser/partmetadata.h b/framework/src/domain/mime/mimetreeparser/partmetadata.h index 41399837..b0f2674e 100644 --- a/framework/src/domain/mime/mimetreeparser/partmetadata.h +++ b/framework/src/domain/mime/mimetreeparser/partmetadata.h | |||
@@ -34,7 +34,6 @@ public: | |||
34 | isGoodSignature(false), | 34 | isGoodSignature(false), |
35 | isEncrypted(false), | 35 | isEncrypted(false), |
36 | isDecryptable(false), | 36 | isDecryptable(false), |
37 | inProgress(false), | ||
38 | technicalProblem(false), | 37 | technicalProblem(false), |
39 | isEncapsulatedRfc822Message(false) | 38 | isEncapsulatedRfc822Message(false) |
40 | { | 39 | { |
@@ -56,7 +55,6 @@ public: | |||
56 | bool isGoodSignature : 1; | 55 | bool isGoodSignature : 1; |
57 | bool isEncrypted : 1; | 56 | bool isEncrypted : 1; |
58 | bool isDecryptable : 1; | 57 | bool isDecryptable : 1; |
59 | bool inProgress : 1; | ||
60 | bool technicalProblem : 1; | 58 | bool technicalProblem : 1; |
61 | bool isEncapsulatedRfc822Message : 1; | 59 | bool isEncapsulatedRfc822Message : 1; |
62 | }; | 60 | }; |