It's unclear how thread-safe the constructor/protocol access is,

so let's guard it.

1 files changed, 6 insertions, 0 deletions

diff --git a/framework/src/domain/mime/mailcrypto.cpp b/framework/src/domain/mime/mailcrypto.cpp
index 8cf55089..a4723199 100644
--- a/framework/src/domain/mime/mailcrypto.cpp
+++ b/framework/src/domain/mime/mailcrypto.cpp
@@ -32,6 +32,8 @@
 #include <gpgme++/keylistresult.h>
 #include <gpgme++/importresult.h>
 #include <QDebug>
+#include <QMutex>
+#include <QMutexLocker>
 
 /*
  * FIXME:
@@ -471,12 +473,16 @@ void MailCrypto::importKeys(const std::vector<GpgME::Key> &keys)
     job->exec(keys);
 }
 
+QMutex sMutex;
+
 std::vector<GpgME::Key> MailCrypto::findKeys(const QStringList &filter, bool findPrivate, bool remote, Protocol protocol)
 {
+    QMutexLocker locker{&sMutex};
     const QGpgME::Protocol *const backend = protocol == SMIME ? QGpgME::smime() : QGpgME::openpgp();
     Q_ASSERT(backend);
     QGpgME::KeyListJob *job = backend->keyListJob(remote);
     Q_ASSERT(job);
+    locker.unlock();
 
     std::vector<GpgME::Key> keys;
     GpgME::KeyListResult res = job->exec(filter, findPrivate, keys);