diff options
author | Christian Mollekopf <chrigi_1@fastmail.fm> | 2018-03-02 15:40:32 +0100 |
---|---|---|
committer | Christian Mollekopf <chrigi_1@fastmail.fm> | 2018-03-02 15:40:32 +0100 |
commit | 330fe2ce9372bace91ac03ae1b5401027509242a (patch) | |
tree | 15d1d65d6f52ae3cacda45bef524485f76cea3d7 /framework/src | |
parent | 8c7e8cb8ebd7f42afde73cb6e41bb3b6bac1b942 (diff) | |
download | kube-330fe2ce9372bace91ac03ae1b5401027509242a.tar.gz kube-330fe2ce9372bace91ac03ae1b5401027509242a.zip |
Revert "Support encrypted mails forwarding"
This reverts commit f28ec43dca5b2915deb69d54fb942ddf1303f48c.
That was pushed by accident.
Diffstat (limited to 'framework/src')
-rw-r--r-- | framework/src/domain/composercontroller.cpp | 21 | ||||
-rw-r--r-- | framework/src/domain/mime/mailtemplates.cpp | 83 |
2 files changed, 16 insertions, 88 deletions
diff --git a/framework/src/domain/composercontroller.cpp b/framework/src/domain/composercontroller.cpp index 2286a71b..09d4c154 100644 --- a/framework/src/domain/composercontroller.cpp +++ b/framework/src/domain/composercontroller.cpp | |||
@@ -99,19 +99,19 @@ class AddresseeController : public Kube::ListPropertyController | |||
99 | public: | 99 | public: |
100 | 100 | ||
101 | bool mFoundAllKeys = true; | 101 | bool mFoundAllKeys = true; |
102 | |||
103 | QSet<QByteArray> mMissingKeys; | 102 | QSet<QByteArray> mMissingKeys; |
104 | AddresseeController() : Kube::ListPropertyController{{"name", "keyFound", "key"}} | 103 | AddresseeController() |
104 | : Kube::ListPropertyController{{"name", "keyFound", "key"}} | ||
105 | { | 105 | { |
106 | QObject::connect( | 106 | QObject::connect(this, &Kube::ListPropertyController::added, this, [this] (const QByteArray &id, const QVariantMap &map) { |
107 | this, &Kube::ListPropertyController::added, this, [this](const QByteArray &id, const QVariantMap &map) { | 107 | findKey(id, map.value("name").toString()); |
108 | findKey(id, map.value("name").toString()); | 108 | }); |
109 | }); | ||
110 | |||
111 | QObject::connect(this, &Kube::ListPropertyController::removed, this, [this] (const QByteArray &id) { | 109 | QObject::connect(this, &Kube::ListPropertyController::removed, this, [this] (const QByteArray &id) { |
112 | mMissingKeys.remove(id); | 110 | mMissingKeys.remove(id); |
113 | setFoundAllKeys(mMissingKeys.isEmpty()); | 111 | setFoundAllKeys(mMissingKeys.isEmpty()); |
114 | }); | 112 | }); |
113 | |||
114 | |||
115 | } | 115 | } |
116 | 116 | ||
117 | bool foundAllKeys() | 117 | bool foundAllKeys() |
@@ -133,13 +133,12 @@ public: | |||
133 | mb.fromUnicodeString(addressee); | 133 | mb.fromUnicodeString(addressee); |
134 | 134 | ||
135 | SinkLog() << "Searching key for: " << mb.address(); | 135 | SinkLog() << "Searching key for: " << mb.address(); |
136 | asyncRun<std::vector<GpgME::Key>>(this, | 136 | asyncRun<std::vector<GpgME::Key>>(this, [mb] { |
137 | [mb] { | ||
138 | return MailCrypto::findKeys(QStringList{} << mb.address(), false, false, MailCrypto::OPENPGP); | 137 | return MailCrypto::findKeys(QStringList{} << mb.address(), false, false, MailCrypto::OPENPGP); |
139 | }, | 138 | }, |
140 | [this, addressee, id](const std::vector<GpgME::Key> &keys) { | 139 | [this, addressee, id](const std::vector<GpgME::Key> &keys) { |
141 | if (!keys.empty()) { | 140 | if (!keys.empty()) { |
142 | if (keys.size() > 1) { | 141 | if (keys.size() > 1 ) { |
143 | SinkWarning() << "Found more than one key, encrypting to all of them."; | 142 | SinkWarning() << "Found more than one key, encrypting to all of them."; |
144 | } | 143 | } |
145 | SinkLog() << "Found key: " << keys.front().primaryFingerprint(); | 144 | SinkLog() << "Found key: " << keys.front().primaryFingerprint(); |
@@ -155,7 +154,7 @@ public: | |||
155 | 154 | ||
156 | void set(const QStringList &list) | 155 | void set(const QStringList &list) |
157 | { | 156 | { |
158 | for (const auto &email : list) { | 157 | for (const auto &email: list) { |
159 | add({{"name", email}}); | 158 | add({{"name", email}}); |
160 | } | 159 | } |
161 | } | 160 | } |
diff --git a/framework/src/domain/mime/mailtemplates.cpp b/framework/src/domain/mime/mailtemplates.cpp index 513f0353..8e644b34 100644 --- a/framework/src/domain/mime/mailtemplates.cpp +++ b/framework/src/domain/mime/mailtemplates.cpp | |||
@@ -53,18 +53,6 @@ static bool operator==(const KMime::Types::Mailbox &left, const KMime::Types::Ma | |||
53 | return (left.addrSpec().asString() == right.addrSpec().asString()); | 53 | return (left.addrSpec().asString() == right.addrSpec().asString()); |
54 | } | 54 | } |
55 | } | 55 | } |
56 | |||
57 | Message* contentToMessage(Content* content) { | ||
58 | content->assemble(); | ||
59 | const auto encoded = content->encodedContent(); | ||
60 | |||
61 | auto message = new Message(); | ||
62 | message->setContent(encoded); | ||
63 | message->parse(); | ||
64 | |||
65 | return message; | ||
66 | } | ||
67 | |||
68 | } | 56 | } |
69 | 57 | ||
70 | static KMime::Types::Mailbox::List stripMyAddressesFromAddressList(const KMime::Types::Mailbox::List &list, const KMime::Types::AddrSpecList me) | 58 | static KMime::Types::Mailbox::List stripMyAddressesFromAddressList(const KMime::Types::Mailbox::List &list, const KMime::Types::AddrSpecList me) |
@@ -235,19 +223,6 @@ KMime::Content *createMultipartAlternativeContent(const QString &plainBody, cons | |||
235 | return multipartAlternative; | 223 | return multipartAlternative; |
236 | } | 224 | } |
237 | 225 | ||
238 | KMime::Message *createMultipartMixedContent(QVector<KMime::Content *> contents) | ||
239 | { | ||
240 | KMime::Message *multiPartMixed = new KMime::Message(); | ||
241 | multiPartMixed->contentType()->setMimeType("multipart/mixed"); | ||
242 | multiPartMixed->contentType()->setBoundary(KMime::multiPartBoundary()); | ||
243 | |||
244 | for (const auto &content : contents) { | ||
245 | multiPartMixed->addContent(content); | ||
246 | } | ||
247 | |||
248 | return multiPartMixed; | ||
249 | } | ||
250 | |||
251 | void addProcessedBodyToMessage(const KMime::Message::Ptr &msg, const QString &plainBody, const QString &htmlBody, bool forward) | 226 | void addProcessedBodyToMessage(const KMime::Message::Ptr &msg, const QString &plainBody, const QString &htmlBody, bool forward) |
252 | { | 227 | { |
253 | //FIXME | 228 | //FIXME |
@@ -889,73 +864,27 @@ void MailTemplates::reply(const KMime::Message::Ptr &origMsg, const std::functio | |||
889 | }); | 864 | }); |
890 | } | 865 | } |
891 | 866 | ||
892 | void MailTemplates::forward(const KMime::Message::Ptr &origMsg, | 867 | void MailTemplates::forward(const KMime::Message::Ptr &origMsg, const std::function<void(const KMime::Message::Ptr &result)> &callback) |
893 | const std::function<void(const KMime::Message::Ptr &result)> &callback) | ||
894 | { | 868 | { |
895 | KMime::Message::Ptr wrapperMsg(new KMime::Message); | 869 | KMime::Message::Ptr wrapperMsg(new KMime::Message); |
896 | 870 | ||
897 | wrapperMsg->to()->clear(); | 871 | wrapperMsg->to()->clear(); |
898 | wrapperMsg->cc()->clear(); | 872 | wrapperMsg->cc()->clear(); |
899 | 873 | ||
900 | // Decrypt the original message, it will be encrypted again in the composer | 874 | wrapperMsg->subject()->fromUnicodeString(forwardSubject(origMsg->subject()->asUnicodeString()), "utf-8"); |
901 | // for the right recipient | ||
902 | KMime::Message::Ptr forwardedMessage; | ||
903 | if (isEncrypted(origMsg.data())) { | ||
904 | qDebug() << "Original message was encrypted, decrypting it"; | ||
905 | MimeTreeParser::ObjectTreeParser otp; | ||
906 | otp.parseObjectTree(origMsg.data()); | ||
907 | otp.decryptParts(); | ||
908 | |||
909 | auto htmlContent = otp.htmlContent(); | ||
910 | KMime::Content *recreatedMsg = | ||
911 | htmlContent.isEmpty() ? createPlainPartContent(otp.plainTextContent()) : | ||
912 | createMultipartAlternativeContent(otp.plainTextContent(), htmlContent); | ||
913 | 875 | ||
914 | if (hasAttachment(origMsg.data())) { | 876 | const QByteArray refStr = getRefStr(origMsg); |
915 | QVector<KMime::Content *> contents = {recreatedMsg}; | ||
916 | contents.append(origMsg->attachments()); | ||
917 | |||
918 | auto msg = createMultipartMixedContent(contents); | ||
919 | |||
920 | forwardedMessage.reset(KMime::contentToMessage(msg)); | ||
921 | } else { | ||
922 | forwardedMessage.reset(KMime::contentToMessage(recreatedMsg)); | ||
923 | } | ||
924 | |||
925 | forwardedMessage->subject()->from7BitString(origMsg->subject()->as7BitString()); | ||
926 | |||
927 | for (const auto &addr : origMsg->to()->mailboxes()) { | ||
928 | forwardedMessage->to()->addAddress(addr); | ||
929 | } | ||
930 | |||
931 | for (const auto &addr : origMsg->cc()->mailboxes()) { | ||
932 | forwardedMessage->cc()->addAddress(addr); | ||
933 | } | ||
934 | |||
935 | for (const auto &addr : origMsg->bcc()->mailboxes()) { | ||
936 | forwardedMessage->bcc()->addAddress(addr); | ||
937 | } | ||
938 | |||
939 | } else { | ||
940 | qDebug() << "Original message was not encrypted, using it as-is"; | ||
941 | forwardedMessage = origMsg; | ||
942 | } | ||
943 | |||
944 | wrapperMsg->subject()->fromUnicodeString( | ||
945 | forwardSubject(forwardedMessage->subject()->asUnicodeString()), "utf-8"); | ||
946 | |||
947 | const QByteArray refStr = getRefStr(forwardedMessage); | ||
948 | if (!refStr.isEmpty()) { | 877 | if (!refStr.isEmpty()) { |
949 | wrapperMsg->references()->fromUnicodeString(QString::fromLocal8Bit(refStr), "utf-8"); | 878 | wrapperMsg->references()->fromUnicodeString(QString::fromLocal8Bit(refStr), "utf-8"); |
950 | } | 879 | } |
951 | 880 | ||
952 | KMime::Content *fwdAttachment = new KMime::Content; | 881 | KMime::Content* fwdAttachment = new KMime::Content; |
953 | 882 | ||
954 | fwdAttachment->contentDisposition()->setDisposition(KMime::Headers::CDinline); | 883 | fwdAttachment->contentDisposition()->setDisposition(KMime::Headers::CDinline); |
955 | fwdAttachment->contentType()->setMimeType("message/rfc822"); | 884 | fwdAttachment->contentType()->setMimeType("message/rfc822"); |
956 | fwdAttachment->contentDisposition()->setFilename(forwardedMessage->subject()->asUnicodeString() + ".eml"); | 885 | fwdAttachment->contentDisposition()->setFilename(origMsg->subject()->asUnicodeString() + ".eml"); |
957 | // The mail was parsed in loadMessage before, so no need to assemble it | 886 | // The mail was parsed in loadMessage before, so no need to assemble it |
958 | fwdAttachment->setBody(forwardedMessage->encodedContent()); | 887 | fwdAttachment->setBody(origMsg->encodedContent()); |
959 | 888 | ||
960 | wrapperMsg->addContent(fwdAttachment); | 889 | wrapperMsg->addContent(fwdAttachment); |
961 | wrapperMsg->assemble(); | 890 | wrapperMsg->assemble(); |