Don't thread drafts and sent

To do this we:
* Expose from the model wether or not the model is threaded
* Set the relevant properties from the model on the controller (so we
  can switch between aggregate and non-aggregate versions)
* Keep the controller in the view it belongs to.

While this works it highlights a couple of issues:
* Controllers are view specific and should be kept within the view.
* The actions we execute in the controller are closely related to the
  model. The model is essentially what the user sees, and therefore what
  he operatees on.
* Sink should perhaps expose aggregates better. We have to pass around
  the values from the model because the model dispatches between
  aggregate and non-aggregate property depending on the threaded state.
  Similary the controller operates on the thread or not depending on the
  threaded state. Perhaps it would be more useful if sink actually
  returned the aggregate somehow, with the regular properties. That way
  the controller could use the regular properties from the entity it
  gets (which would simply either be the aggregate or non-aggregate
  depending on the executed query). If the aggregate already contains
  all matched ids, then we would also not have to execute an additional
  query to get the thread again, the modification would simply be
  applied to all ids originally returned.

1 files changed, 16 insertions, 16 deletions

diff --git a/framework/src/domain/mailcontroller.cpp b/framework/src/domain/mailcontroller.cpp
index fe02afc3..a6c5c555 100644
--- a/framework/src/domain/mailcontroller.cpp
+++ b/framework/src/domain/mailcontroller.cpp
@@ -39,7 +39,10 @@ MailController::MailController()
     action_moveToFolder{new Kube::ControllerAction{this, &MailController::moveToFolder}}
 {
     QObject::connect(this, &MailController::mailChanged, &MailController::updateActions);
-    QObject::connect(this, &MailController::threadLeaderChanged, &MailController::updateActions);
+    QObject::connect(this, &MailController::importantChanged, &MailController::updateActions);
+    QObject::connect(this, &MailController::draftChanged, &MailController::updateActions);
+    QObject::connect(this, &MailController::trashChanged, &MailController::updateActions);
+    QObject::connect(this, &MailController::unreadChanged, &MailController::updateActions);
     updateActions();
 }
 
@@ -47,24 +50,21 @@ void MailController::runModification(const std::function<void(ApplicationDomain:
 {
     if (auto mail = getMail()) {
         f(*mail);
-        run(Store::modify(*mail));
-    } else if (auto mail = getThreadLeader()) {
-        f(*mail);
-        run(Store::modify(Sink::StandardQueries::completeThread(*mail), *mail));
+        if (getOperateOnThreads()) {
+            run(Store::modify(Sink::StandardQueries::completeThread(*mail), *mail));
+        } else {
+            run(Store::modify(*mail));
+        }
     }
 }
 
 void MailController::updateActions()
 {
-    auto mail = getMail();
-    if (!mail) {
-        mail= getThreadLeader();
-    }
-    if (mail) {
-        action_moveToTrash->setEnabled(!mail->getTrash());
-        action_restoreFromTrash->setEnabled(mail->getTrash());
-        action_markAsRead->setEnabled(mail->getUnread());
-        action_markAsUnread->setEnabled(!mail->getUnread());
+    if (auto mail = getMail()) {
+        action_moveToTrash->setEnabled(!getTrash());
+        action_restoreFromTrash->setEnabled(getTrash());
+        action_markAsRead->setEnabled(getUnread());
+        action_markAsUnread->setEnabled(getUnread());
     } else {
         action_moveToTrash->setEnabled(false);
         action_restoreFromTrash->setEnabled(false);
@@ -99,8 +99,8 @@ void MailController::markAsImportant()
 
 void MailController::toggleImportant()
 {
-    runModification([] (ApplicationDomain::Mail &mail) {
-        mail.setImportant(!mail.getImportant());
+    runModification([this] (ApplicationDomain::Mail &mail) {
+        mail.setImportant(!getImportant());
         SinkLog() << "Toggle important " << mail.identifier() << mail.getImportant();
     });
 }