diff options
author | Rémi Nicole <nicole@kolabsystems.com> | 2018-03-09 13:32:10 +0100 |
---|---|---|
committer | Christian Mollekopf <chrigi_1@fastmail.fm> | 2018-03-09 13:32:24 +0100 |
commit | d5b5c33a0cb3fbe02d011a14f2028249220b0656 (patch) | |
tree | db0ebb30db599a6889ea6066ec33bf5f862c8444 /framework/qml/MailViewer.qml | |
parent | 93e9c10d1894797b5826bbdfcc324f4235c9e193 (diff) | |
download | kube-d5b5c33a0cb3fbe02d011a14f2028249220b0656.tar.gz kube-d5b5c33a0cb3fbe02d011a14f2028249220b0656.zip |
Automatic key import / export + Expected monad
Summary:
There are many things going on here (perhaps a bit much for a single patch):
- When an attachment is of mime type "application/pgp-keys", a button is added to import the key to GPG
- When sending a mail and crypto is enabled (encryption, signing or both), the public key of the first private key found is sent as an un-encrypted attachment (T6994)
- The `mailcrypto.{h,cpp}` was, for the most part, rewritten
- Introduction of the expected monad, inspired by what was proposed for C++ [here](https://isocpp.org/files/papers/n4015.pdf), but not at all a strict implementation of this specification. We may want to add some more features of this standard later.
The rationale for some of the choices:
- I found mailcrypto a bit hard to edit to add new features, and a great part was commented code to prepare for the support the SMIME crypto format, which would (in my current knowledge) not be used for sending emails.
- One thing I found that may be missing in the code base was a standardized way of handling errors in C++ code. Since exceptions are disabled I think that the functional way is the way to go. After some research I found the Expected monad / tagged union / sum type, which seemed to suit the problem particularly well.
In the long run, I hope we would move the entire code base to use `Expected` to indicate if a function might fail.
Of course every choice made here is to be considered as a proposition for doing things / RFC, critics wholeheartedly accepted.
Reviewers: cmollekopf
Tags: #kube
Maniphest Tasks: T6994, T8147, T6995
Differential Revision: https://phabricator.kde.org/D11158
Diffstat (limited to 'framework/qml/MailViewer.qml')
-rw-r--r-- | framework/qml/MailViewer.qml | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/framework/qml/MailViewer.qml b/framework/qml/MailViewer.qml index 565adedd..e9ffd108 100644 --- a/framework/qml/MailViewer.qml +++ b/framework/qml/MailViewer.qml | |||
@@ -283,6 +283,7 @@ Rectangle { | |||
283 | 283 | ||
284 | delegate: AttachmentDelegate { | 284 | delegate: AttachmentDelegate { |
285 | name: model.name | 285 | name: model.name |
286 | type: model.type | ||
286 | icon: model.iconName | 287 | icon: model.iconName |
287 | 288 | ||
288 | clip: true | 289 | clip: true |
@@ -290,6 +291,7 @@ Rectangle { | |||
290 | actionIcon: Kube.Icons.save_inverted | 291 | actionIcon: Kube.Icons.save_inverted |
291 | onExecute: messageParser.attachments.saveAttachmentToDisk(messageParser.attachments.index(index, 0)) | 292 | onExecute: messageParser.attachments.saveAttachmentToDisk(messageParser.attachments.index(index, 0)) |
292 | onClicked: messageParser.attachments.openAttachment(messageParser.attachments.index(index, 0)) | 293 | onClicked: messageParser.attachments.openAttachment(messageParser.attachments.index(index, 0)) |
294 | onPublicKeyImport: messageParser.attachments.importPublicKey(messageParser.attachments.index(index, 0)) | ||
293 | } | 295 | } |
294 | } | 296 | } |
295 | } | 297 | } |