[Mac/Win] : add application icon

https: //phabricator.kde.org/D4993
Committed from host : Portia.local

1 files changed, 19 insertions, 3 deletions

diff --git a/applications/mail/CMakeLists.txt b/applications/mail/CMakeLists.txt
index 7c6fe755..56bbf98a 100644
--- a/applications/mail/CMakeLists.txt
+++ b/applications/mail/CMakeLists.txt
@@ -5,11 +5,18 @@ cmake_policy(SET CMP0063 NEW)
 
 include(CPack)
 include(FeatureSummary)
+
 find_package(PkgConfig)
 
 ################# set KDE specific information #################
 
-find_package(ECM 0.0.8 REQUIRED NO_MODULE)
+if(APPLE OR WIN32)
+    # for an ecm_add_app_icon() implementation acception svg icons
+    set(ECM_MIN_VERSION 5.29.0)
+else()
+    set(ECM_MIN_VERSION 0.0.8)
+endif()
+find_package(ECM ${ECM_MIN_VERSION} REQUIRED NO_MODULE)
 
 # where to look first for cmake modules, before ${CMAKE_ROOT}/Modules/ is checked
 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR})
@@ -17,6 +24,7 @@ set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_D
 include(KDEInstallDirs)
 include(KDECMakeSettings)
 include(KDECompilerSettings)
+include(ECMAddAppIcon)
 
 find_package(Qt5 REQUIRED NO_MODULE COMPONENTS Core Quick Test Gui Widgets WebEngine)
 
@@ -24,11 +32,19 @@ set (QT_MIN_VERSION "5.6.0")
 find_package(KF5 REQUIRED COMPONENTS Package)
 
 # install executable
-add_executable(${PROJECT_NAME} main.cpp)
+set(kube_mail_SRCS main.cpp)
+
+if(APPLE OR WIN32)
+    # Sets the icon on Windows and OSX
+    file(GLOB ICONS_SRCS "${CMAKE_CURRENT_SOURCE_DIR}/../../icons/*-apps-kube_icon.*")
+    ecm_add_app_icon(kube_mail_SRCS ICONS ${ICONS_SRCS})
+endif()
+
+add_executable(${PROJECT_NAME} ${kube_mail_SRCS})
 qt5_use_modules(${PROJECT_NAME} Gui Quick Widgets WebEngine)
 target_link_libraries(${PROJECT_NAME} KF5::Package)
 
-install(TARGETS ${PROJECT_NAME} DESTINATION bin)
+install(TARGETS ${PROJECT_NAME} DESTINATION ${KDE_INSTALL_TARGETS_DEFAULT_ARGS})
 
 install(PROGRAMS org.kde.kube.desktop DESTINATION ${KDE_INSTALL_APPDIR} )
 install(FILES org.kde.kube.appdata.xml DESTINATION ${KDE_INSTALL_DATAROOTDIR}/appdata/)