summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristian Mollekopf <chrigi_1@fastmail.fm>2017-03-26 19:37:42 +0200
committerChristian Mollekopf <chrigi_1@fastmail.fm>2017-03-26 19:37:42 +0200
commitf928c3fcde9e6089e566484802a34b6e201acab5 (patch)
treedc9725c3d982a08d8f3b4bf5be03d76858b4f5d4
parentefa15f1d81f91b2a5fd2e35a9ecb1f5c17515b4b (diff)
downloadsink-f928c3fcde9e6089e566484802a34b6e201acab5.tar.gz
sink-f928c3fcde9e6089e566484802a34b6e201acab5.zip
Don't filter notifications too early.
With this it becomes difficult to test notifications, and notifications may contain more interesting information, so we don't want to drop them too early.
-rw-r--r--common/resourceaccess.cpp8
1 files changed, 3 insertions, 5 deletions
diff --git a/common/resourceaccess.cpp b/common/resourceaccess.cpp
index 9f4f14c..ad8cae9 100644
--- a/common/resourceaccess.cpp
+++ b/common/resourceaccess.cpp
@@ -602,12 +602,10 @@ bool ResourceAccess::processMessageBuffer()
602 queuedInvoke([=]() { emit notification(n); }, this); 602 queuedInvoke([=]() { emit notification(n); }, this);
603 } break; 603 } break;
604 case Sink::Notification::Status: 604 case Sink::Notification::Status:
605 if (mResourceStatus == buffer->code()) { 605 if (mResourceStatus != buffer->code()) {
606 SinkTrace() << "Got an unnecessary status notification: " << buffer->code(); 606 mResourceStatus = buffer->code();
607 break; 607 SinkTrace() << "Updated status: " << mResourceStatus;
608 } 608 }
609 mResourceStatus = buffer->code();
610 SinkTrace() << "Updated status: " << mResourceStatus;
611 [[clang::fallthrough]]; 609 [[clang::fallthrough]];
612 case Sink::Notification::Info: 610 case Sink::Notification::Info:
613 [[clang::fallthrough]]; 611 [[clang::fallthrough]];