From a3c3fb61e08523a563ce3cba86dc50c9c5fc2c5d Mon Sep 17 00:00:00 2001
From: Christian Mollekopf <chrigi_1@fastmail.fm>
Date: Wed, 13 Jul 2016 14:43:37 +0200
Subject: Fixed new diagnostics errors

---
 tests/hawd/dataset.cpp           | 2 +-
 tests/hawd/datasetdefinition.cpp | 2 +-
 tests/mailtest.cpp               | 2 +-
 tests/storagetest.cpp            | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

(limited to 'tests')

diff --git a/tests/hawd/dataset.cpp b/tests/hawd/dataset.cpp
index 372a4b6..c023f31 100644
--- a/tests/hawd/dataset.cpp
+++ b/tests/hawd/dataset.cpp
@@ -216,7 +216,7 @@ QString Dataset::Row::toString(const QStringList &cols, int standardCols, const
 Dataset::Dataset(const QString &name, const State &state)
     : m_definition(state.datasetDefinition(name)),
       m_storage(state.resultsPath(), name, Sink::Storage::ReadWrite),
-      m_transaction(std::move(m_storage.createTransaction())),
+      m_transaction(m_storage.createTransaction()),
       m_commitHash(state.commitHash())
 {
 }
diff --git a/tests/hawd/datasetdefinition.cpp b/tests/hawd/datasetdefinition.cpp
index e2af2b9..9b7a20b 100644
--- a/tests/hawd/datasetdefinition.cpp
+++ b/tests/hawd/datasetdefinition.cpp
@@ -121,7 +121,7 @@ DatasetDefinition::DatasetDefinition(const QString &path)
 
             m_description = json.value("description").toString();
             auto cols = json.value("columns").toArray();
-            for (const auto &entry: cols) {
+            for (QJsonValueRef entry: cols) {
                 QJsonObject def = entry.toObject();
                 if (!def.isEmpty()) {
                     m_columns << qMakePair(def.value("name").toString(), DataDefinition(def));
diff --git a/tests/mailtest.cpp b/tests/mailtest.cpp
index 2547536..908fb84 100644
--- a/tests/mailtest.cpp
+++ b/tests/mailtest.cpp
@@ -354,7 +354,7 @@ void MailTest::testCreateDraft()
     {
         auto mails = Store::read<ApplicationDomain::Mail>(Query().filter<Mail::Folder>(folderIdentifier));
         bool found = false;
-        for (const auto m : mails) {
+        for (const auto &m : mails) {
             if (m.identifier() == mail.identifier()) {
                 found = true;
             }
diff --git a/tests/storagetest.cpp b/tests/storagetest.cpp
index e199faf..aa12ec1 100644
--- a/tests/storagetest.cpp
+++ b/tests/storagetest.cpp
@@ -28,7 +28,7 @@ private:
             if (i % 10000 == 0) {
                 if (i > 0) {
                     transaction.commit();
-                    transaction = std::move(storage.createTransaction(Sink::Storage::ReadWrite));
+                    transaction = storage.createTransaction(Sink::Storage::ReadWrite);
                 }
             }
             transaction.openDatabase().write(keyPrefix + QByteArray::number(i), keyPrefix + QByteArray::number(i));
-- 
cgit v1.2.3