From 1d713d9e2dbaf27de9da087f9270d260dfc40c31 Mon Sep 17 00:00:00 2001
From: Christian Mollekopf <chrigi_1@fastmail.fm>
Date: Mon, 21 Nov 2016 23:13:38 +0100
Subject: Folded the SourceWriteback into the Synchronizer.

By concentrating all communication to the source in one place we get rid
of several oddities.
* Quite a bit of duplication since both need access to the
  synchronizationStore and the source.
* We currently have an akward locking in place because both classes
  access the ync store. This is not easier to resolve cleanly.
* The live of resource implementers becomes easier.
* An implementation could elect to not use changereplay and always do a
  full sync... (maybe?)
---
 examples/imapresource/imapresource.cpp | 23 -----------------------
 1 file changed, 23 deletions(-)

(limited to 'examples/imapresource/imapresource.cpp')

diff --git a/examples/imapresource/imapresource.cpp b/examples/imapresource/imapresource.cpp
index 2b9659e..8fc7702 100644
--- a/examples/imapresource/imapresource.cpp
+++ b/examples/imapresource/imapresource.cpp
@@ -28,7 +28,6 @@
 #include "definitions.h"
 #include "inspection.h"
 #include "synchronizer.h"
-#include "sourcewriteback.h"
 #include "remoteidmap.h"
 #include "query.h"
 
@@ -393,22 +392,6 @@ public:
         return KAsync::error<void>("Nothing to do");
     }
 
-public:
-    QString mServer;
-    int mPort;
-    QString mUser;
-    QString mPassword;
-    QByteArray mResourceInstanceIdentifier;
-};
-
-class ImapWriteback : public Sink::SourceWriteBack
-{
-public:
-    ImapWriteback(const ResourceContext &resourceContext) : Sink::SourceWriteBack(resourceContext)
-    {
-
-    }
-
     KAsync::Job<QByteArray> replay(const ApplicationDomain::Mail &mail, Sink::Operation operation, const QByteArray &oldRemoteId, const QList<QByteArray> &changedProperties) Q_DECL_OVERRIDE
     {
         auto imap = QSharedPointer<ImapServerProxy>::create(mServer, mPort);
@@ -595,12 +578,6 @@ ImapResource::ImapResource(const ResourceContext &resourceContext, const QShared
     synchronizer->mUser = mUser;
     synchronizer->mPassword = mPassword;
     setupSynchronizer(synchronizer);
-    auto changereplay = QSharedPointer<ImapWriteback>::create(resourceContext);
-    changereplay->mServer = mServer;
-    changereplay->mPort = mPort;
-    changereplay->mUser = mUser;
-    changereplay->mPassword = mPassword;
-    setupChangereplay(changereplay);
 
     setupPreprocessors(ENTITY_TYPE_MAIL, QVector<Sink::Preprocessor*>() << new SpecialPurposeProcessor(resourceContext.resourceType, resourceContext.instanceId()) << new MimeMessageMover << new MailPropertyExtractor);
     setupPreprocessors(ENTITY_TYPE_FOLDER, QVector<Sink::Preprocessor*>());
-- 
cgit v1.2.3