From 984321d6a7e7f4e0debdf097c45ebe32ba514194 Mon Sep 17 00:00:00 2001
From: Christian Mollekopf <chrigi_1@fastmail.fm>
Date: Thu, 9 Apr 2015 21:19:45 +0200
Subject: comments

---
 dummyresource/facade.cpp | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'dummyresource/facade.cpp')

diff --git a/dummyresource/facade.cpp b/dummyresource/facade.cpp
index 980833f..af8c187 100644
--- a/dummyresource/facade.cpp
+++ b/dummyresource/facade.cpp
@@ -136,6 +136,7 @@ void DummyResourceFacade::readValue(QSharedPointer<Akonadi2::Storage> storage, c
             auto adaptor = mFactory->createAdaptor(buffer.entity());
             //TODO only copy requested properties
             auto memoryAdaptor = QSharedPointer<Akonadi2::ApplicationDomain::MemoryBufferAdaptor>::create(*adaptor);
+            // here we could copy additional properties that don't have a 1:1 mapping, such as separately stored tags.
             auto event = QSharedPointer<Akonadi2::ApplicationDomain::Event>::create("org.kde.dummy", QByteArray::fromRawData(static_cast<char*>(keyValue), keySize), revision, memoryAdaptor);
             resultCallback(event);
         }
@@ -154,6 +155,8 @@ Async::Job<void> DummyResourceFacade::load(const Akonadi2::Query &query, const s
 
         auto storage = QSharedPointer<Akonadi2::Storage>::create(Akonadi2::Store::storageLocation(), "org.kde.dummy");
 
+        //TODO use transaction over full query and record store revision. We'll need it to update the query.
+
         //Index lookups
         QVector<QByteArray> keys;
         if (query.propertyFilter.contains("uid")) {
-- 
cgit v1.2.3