From aa449c82dc3a5505b8a63843b83aed0f5dab8ed1 Mon Sep 17 00:00:00 2001
From: Christian Mollekopf <chrigi_1@fastmail.fm>
Date: Fri, 30 Jan 2015 12:00:36 +0100
Subject: clenup

---
 common/clientapi.cpp | 8 +-------
 common/clientapi.h   | 7 +------
 common/pipeline.cpp  | 1 -
 3 files changed, 2 insertions(+), 14 deletions(-)

(limited to 'common')

diff --git a/common/clientapi.cpp b/common/clientapi.cpp
index 260b6b8..190bb57 100644
--- a/common/clientapi.cpp
+++ b/common/clientapi.cpp
@@ -6,14 +6,8 @@
 namespace async
 {
     void run(const std::function<void()> &runner) {
+        //TODO use a job that runs in a thread?
         QtConcurrent::run(runner);
-
-        // //FIXME we should be using a Job instead of a timer
-        // auto timer = new QTimer;
-        // timer->setSingleShot(true);
-        // QObject::connect(timer, &QTimer::timeout, runner);
-        // QObject::connect(timer, &QTimer::timeout, timer, &QObject::deleteLater);
-        // timer->start(0);
     };
 } // namespace async
 
diff --git a/common/clientapi.h b/common/clientapi.h
index 71317a1..6b41116 100644
--- a/common/clientapi.h
+++ b/common/clientapi.h
@@ -333,11 +333,8 @@ public:
 
 /**
  * Facade factory that returns a store facade implementation, by loading a plugin and providing the relevant implementation.
- * 
+ *
  * If we were to provide default implementations for certain capabilities. Here would be the place to do so.
- * 
- * TODO: pluginmechansims for resources to provide their implementations.
- * * We may want a way to recycle facades to avoid recreating socket connections all the time?
  */
 
 class FacadeFactory {
@@ -395,8 +392,6 @@ private:
 
 /**
  * Store interface used in the client API.
- *
- * TODO: For testing we need to be able to inject dummy StoreFacades. Should we work with a store instance, or a singleton factory?
  */
 class Store {
 public:
diff --git a/common/pipeline.cpp b/common/pipeline.cpp
index f440c6d..7cab8ec 100644
--- a/common/pipeline.cpp
+++ b/common/pipeline.cpp
@@ -100,7 +100,6 @@ Async::Job<void> Pipeline::newEntity(void const *command, size_t size)
     //TODO toRFC4122 would probably be more efficient, but results in non-printable keys.
     const auto key = QUuid::createUuid().toString().toUtf8();
 
-    //TODO figure out if we already have created a revision for the message?
     const qint64 newRevision = storage().maxRevision() + 1;
 
     {
-- 
cgit v1.2.3