From 9e6952baf64b51fa7ddb6ac91d4ce79ebfd2b2df Mon Sep 17 00:00:00 2001 From: Heiko Becker Date: Sat, 13 May 2017 00:11:45 +0200 Subject: Use imported targets instead of qt5_use_modules From Qt's documentation: "This macro is obsolete. Use target_link_libraries with IMPORTED targets instead." It's only recommended with cmake >=2.8.9 & < 2.8.12. Sink already requires cmake 3.0. One advantage of using the imported targets is, that cmake complains if a target isn't found before it's used, like Qt5Concurrent missing from the find_package_call here. Reviewers: #sink, cmollekopf Reviewed By: #sink, cmollekopf Subscribers: #sink Tags: #sink Differential Revision: https://phabricator.kde.org/D6361 --- common/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'common') diff --git a/common/CMakeLists.txt b/common/CMakeLists.txt index 001a412..8421fc2 100644 --- a/common/CMakeLists.txt +++ b/common/CMakeLists.txt @@ -116,13 +116,13 @@ SET_TARGET_PROPERTIES(${PROJECT_NAME} EXPORT_NAME ${PROJECT_NAME} ) -qt5_use_modules(${PROJECT_NAME} LINK_PUBLIC Network) -qt5_use_modules(${PROJECT_NAME} LINK_PRIVATE Gui) target_link_libraries(${PROJECT_NAME} PUBLIC KAsync + Qt5::Network PRIVATE ${storage_LIBS} + Qt5::Gui KF5::Mime KF5::Contacts ) -- cgit v1.2.3