From 57e662cadc1f04ce58e34bc08907d7fc75eeb176 Mon Sep 17 00:00:00 2001
From: Christian Mollekopf <chrigi_1@fastmail.fm>
Date: Sun, 8 May 2016 10:11:20 +0200
Subject: Avoid dangling references

---
 common/index.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'common')

diff --git a/common/index.cpp b/common/index.cpp
index b5e9980..151f7af 100644
--- a/common/index.cpp
+++ b/common/index.cpp
@@ -44,6 +44,7 @@ void Index::lookup(const QByteArray &key, const std::function<void(const QByteAr
 QByteArray Index::lookup(const QByteArray &key)
 {
     QByteArray result;
-    lookup(key, [&result](const QByteArray &value) { result = value; }, [this](const Index::Error &error) { Trace() << "Error while retrieving value" << error.message; });
+    //We have to create a deep copy, otherwise the returned data may become invalid when the transaction ends.
+    lookup(key, [&result](const QByteArray &value) { result = QByteArray(value.constData(), value.size()); }, [this](const Index::Error &error) { Trace() << "Error while retrieving value" << error.message; });
     return result;
 }
-- 
cgit v1.2.3