From 016fea734d09df707be9a16a4ad6a1107f41549f Mon Sep 17 00:00:00 2001
From: Minijackson <minijackson@riseup.net>
Date: Wed, 27 Jun 2018 11:12:38 +0200
Subject: Fix pipelinetest + remove useless commented lines

---
 common/storage/entitystore.cpp | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

(limited to 'common/storage')

diff --git a/common/storage/entitystore.cpp b/common/storage/entitystore.cpp
index efafe8a..d3420e4 100644
--- a/common/storage/entitystore.cpp
+++ b/common/storage/entitystore.cpp
@@ -371,8 +371,9 @@ void EntityStore::cleanupEntityRevisionsUntil(qint64 revision)
         return;
     }
     SinkTraceCtx(d->logCtx) << "Cleaning up revision " << revision << uid << bufferType;
+    const auto internalUid = Identifier::fromDisplayByteArray(uid).toInternalByteArray();
     DataStore::mainDatabase(d->transaction, bufferType)
-        .scan(uid,
+        .scan(internalUid,
             [&](const QByteArray &key, const QByteArray &data) -> bool {
                 EntityBuffer buffer(const_cast<const char *>(data.data()), data.size());
                 if (!buffer.isValid()) {
@@ -530,7 +531,6 @@ ApplicationDomain::ApplicationDomainType EntityStore::readLatest(const QByteArra
     return dt;
 }
 
-// TODO: check every usage
 void EntityStore::readEntity(const QByteArray &type, const QByteArray &displayKey, const std::function<void(const QByteArray &uid, const EntityBuffer &entity)> callback)
 {
     const auto key = Key::fromDisplayByteArray(displayKey);
@@ -598,7 +598,6 @@ void EntityStore::readPrevious(const QByteArray &type, const QByteArray &uid, qi
     const auto internalUid = Identifier::fromDisplayByteArray(uid).toInternalByteArray();
     db.scan(internalUid,
         [&latestRevision, revision](const QByteArray &key, const QByteArray &) -> bool {
-            //const auto foundRevision = DataStore::revisionFromKey(key);
             const auto foundRevision = Key::fromInternalByteArray(key).revision().toQint64();
             if (foundRevision < revision && foundRevision > latestRevision) {
                 latestRevision = foundRevision;
@@ -633,11 +632,7 @@ void EntityStore::readAllUids(const QByteArray &type, const std::function<void(c
 
 bool EntityStore::contains(const QByteArray &type, const QByteArray &uid)
 {
-    // Because of pipeline using this function with new entities
-    // TODO: maybe modify pipeline instead?
-    if(uid.isEmpty()) {
-        return false;
-    }
+    Q_ASSERT(!uid.isEmpty());
     const auto internalUid = Identifier::fromDisplayByteArray(uid).toInternalByteArray();
     return DataStore::mainDatabase(d->getTransaction(), type).contains(internalUid);
 }
@@ -675,10 +670,11 @@ void EntityStore::readRevisions(const QByteArray &type, const QByteArray &uid, q
 {
     Q_ASSERT(d);
     Q_ASSERT(!uid.isEmpty());
+    const auto internalUid = Identifier::fromDisplayByteArray(uid).toInternalByteArray();
     DataStore::mainDatabase(d->transaction, type)
-        .scan(uid,
+        .scan(internalUid,
             [&](const QByteArray &key, const QByteArray &value) -> bool {
-                const auto parsedKey = Key::fromDisplayByteArray(key);
+                const auto parsedKey = Key::fromInternalByteArray(key);
                 const auto revision = parsedKey.revision().toQint64();
                 if (revision >= startingRevision) {
                     callback(parsedKey.identifier().toDisplayByteArray(), revision, Sink::EntityBuffer(value.data(), value.size()));
-- 
cgit v1.2.3