summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAge
* Actually store the flags instead of the db name.Christian Mollekopf2018-08-08
| | | | | | | The reason why we didn't notice was probably: * we only use this table nowadays when we have no db layout. * The only flag we ever set is the dupsort flag, and the return from a failed int conversion of 0 is otherwise correct.
* Removed unused codeChristian Mollekopf2018-08-06
|
* Fixed threading issues with dynamic db creation.Christian Mollekopf2018-08-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch addresses two problems: * A potential deadlock. We had the following code inside a separately protected section: dbiLocker.unlock(); //Here we could loos the readlock QWriteLocker dbiWriteLocker(&sDbisLock); If we lost the lock in between the two lines, the second thread that was now holding a read-lock on sDbisLock could not enter the protected section, which was a requirement to release the read-lock, and we'd thus end up in a deadlock. This is solved using tryLock with intermediate releases of the read-lock, allowing the original thread to finish. * When failing to validate a dbi for the current transacation we simply returned an invalid db (which then in this particular case broke reading of revision uid's and type's), leading to queries not executing as they should. Both problems are unfortunately hard to reproduce, the adjusted test at leaset allowed me to reproduce the deadlock situation sometimes. To fix this cleanly we should probably just get rid of dynamic dbi allocation for good.
* Asserts in methods where we always expect a result.Christian Mollekopf2018-08-06
|
* Avoid creating an instance just to check for instanceChristian Mollekopf2018-08-06
|
* Removed the use of C99 extensionsChristian Mollekopf2018-08-03
|
* Improve documentation of SinkSHRémi Nicole2018-08-03
| | | | | | | | | | | | | | | | | | | | | Summary: - Add support for positional arguments, options, flags in the syntax tree - Add automatic generation of usage string TODO: - ~~Better document the `--reduce` option in the `list` command~~ - Get the parent command for sub-commands so we could show help for `trace on` and not just `on` - Pass the syntax to the implementation of the command so commands can easily show help on wrong usage. Also, SyntaxTree could do automatic input validation in the future, this could also help. - Even with the new documentation, some command could still be confusing. Should we add some usage examples? Reviewers: cmollekopf Reviewed By: cmollekopf Tags: #sink Differential Revision: https://phabricator.kde.org/D14547
* Fixed typoChristian Mollekopf2018-08-03
|
* Disable warning that get's triggered by moc generated codeChristian Mollekopf2018-08-03
|
* CleanupChristian Mollekopf2018-08-02
|
* Calendar colorChristian Mollekopf2018-08-02
|
* CleanupChristian Mollekopf2018-08-02
|
* Carddav changereplayChristian Mollekopf2018-08-02
|
* Email debug serializerChristian Mollekopf2018-08-02
|
* CleanupChristian Mollekopf2018-08-02
|
* Cleanup.Christian Mollekopf2018-08-02
|
* Fixed signed/unsigned comparisonChristian Mollekopf2018-07-30
|
* Prevent phrase searches from spanning different indexed partsChristian Mollekopf2018-07-30
|
* An adaptive query limit and a warning if we exceed itChristian Mollekopf2018-07-30
|
* More lsan suppressionsChristian Mollekopf2018-07-30
|
* More lsan suppressionsChristian Mollekopf2018-07-30
|
* more slan suppressionsChristian Mollekopf2018-07-30
|
* Disabled flaky testChristian Mollekopf2018-07-30
|
* Small optimizationChristian Mollekopf2018-07-30
|
* Avoid unnecessary Identifier conversions in performance ciritical code.Christian Mollekopf2018-07-28
| | | | | This fixes the performance regressions to a state where we are roughly at the same performance as pre Identifier (but not any better either).
* Fixed warningsChristian Mollekopf2018-07-28
|
* Don't print all results.Christian Mollekopf2018-07-27
|
* Debug messages and a higher limit for queriesChristian Mollekopf2018-07-27
|
* Fixed storagetestChristian Mollekopf2018-07-27
|
* Fixed buildChristian Mollekopf2018-07-27
|
* Use Key API in SinkSHRémi Nicole2018-07-27
| | | | | | | | | | | | | | | | | | Summary: Depends on D14289 - Fixes the `sinksh inspect …` command - Introduces `isValid`, `isValidInternal` and `isValidDisplay` static functions in Key, Identifier and Revision I still have to do a more extensive search for induced bugs in other commands Reviewers: cmollekopf Reviewed By: cmollekopf Tags: #sink Differential Revision: https://phabricator.kde.org/D14404
* Use Key API in ResultSetRémi Nicole2018-07-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary: Depends on D14099 Notes: - Tests pass without many modifications outside of resultset.cpp/.h - `mGenerator` doesn't seem to be used? Benchmarks ========= Run benchmarks: | Develop | D14099 | This patch | | ---------------------------------- | ---------------------------------- | ---------------------------------- | | Current Rss usage [kb]: 40700 | Current Rss usage [kb]: 38564 | Current Rss usage [kb]: 39112 | | Peak Rss usage [kb]: 40700 | Peak Rss usage [kb]: 38564 | Peak Rss usage [kb]: 39112 | | Rss growth [kb]: 15920 | Rss growth [kb]: 13352 | Rss growth [kb]: 13432 | | Rss growth per entity [byte]: 3260 | Rss growth per entity [byte]: 2734 | Rss growth per entity [byte]: 2750 | | Rss without db [kb]: 29736 | Rss without db [kb]: 29248 | Rss without db [kb]: 30100 | | Percentage peak rss error: 0 | Percentage peak rss error: 0 | Percentage peak rss error: 0 | | On disk [kb]: 10788 | On disk [kb]: 9140 | On disk [kb]: 8836 | | Buffer size total [kb]: 898 | Buffer size total [kb]: 898 | Buffer size total [kb]: 898 | | Write amplification: 12.0075 | Write amplification: 10.1732 | Write amplification: 9.83485 | Test Disk Usage: | Develop | D14099 | This patch | | ----------------------------------- | ----------------------------------- | ----------------------------------- | | Free pages: 412 | Free pages: 309 | Free pages: 312 | | Total pages: 760 | Total pages: 599 | Total pages: 603 | | Used size: 1425408 | Used size: 1187840 | Used size: 1191936 | | Calculated key + value size: 856932 | Calculated key + value size: 702866 | Calculated key + value size: 702866 | | Calculated total db sizes: 970752 | Calculated total db sizes: 954368 | Calculated total db sizes: 933888 | | Main store on disk: 3112960 | Main store on disk: 2453504 | Main store on disk: 2469888 | | Total on disk: 3293184 | Total on disk: 2633728 | Total on disk: 2650112 | | Used size amplification: 1.66339 | Used size amplification: 1.68999 | Used size amplification: 1.69582 | | Write amplification: 3.63268 | Write amplification: 3.49071 | Write amplification: 3.51402 | Reviewers: cmollekopf Reviewed By: cmollekopf Tags: #sink Differential Revision: https://phabricator.kde.org/D14289
* Use Key API in DataStoreQueryRémi Nicole2018-07-27
| | | | | | | | | | Reviewers: cmollekopf Reviewed By: cmollekopf Tags: #sink Differential Revision: https://phabricator.kde.org/D14099
* Use Key API in indexesRémi Nicole2018-07-27
| | | | | | | | | | | | | | | | | | Summary: - Only in TypeIndex, not in Index (since we might want to store something other than identifiers as values) - We might want to do the same in the `SynchronizerStore` for localId ↔ remoteId indexes Depends on D13735 Some quick benchmarks (against develop and D13735): {F6022279} Reviewers: cmollekopf Reviewed By: cmollekopf Tags: #sink Differential Revision: https://phabricator.kde.org/D13902
* New Key API in storage layerRémi Nicole2018-07-27
| | | | | | | | | | | | | | | | | Summary: - Use object oriented paradigm for Keys / Identifiers /Revisions - "Compress" keys by using byte representation of Uuids - Still some cleaning left to do - Also run some benchmarks - I'm questioning whether files other than entitystore (tests excluded) are allowed to access this API Reviewers: cmollekopf Reviewed By: cmollekopf Tags: #sink Differential Revision: https://phabricator.kde.org/D13735
* Shouldn't be a warning if we expect to run into it.Christian Mollekopf2018-07-27
| | | | We always run into that when starting a resource.
* Only do partial matching (instead of wildcard) and limit expansion.Christian Mollekopf2018-07-27
|
* Better querytestChristian Mollekopf2018-07-27
|
* All xapian stuff in a central placeChristian Mollekopf2018-07-27
|
* There isn't even a resource which we could shutdown in this testChristian Mollekopf2018-07-26
|
* This is not a reliable test, so we turn it into a warning instead.Christian Mollekopf2018-07-25
|
* No random timeouts in testsChristian Mollekopf2018-07-25
|
* Avoid the socket probing and move the shutdown logic intoChristian Mollekopf2018-07-25
| | | | | | | | | | | | | | | resourceaccess. The problem was (as excercised by the last test in resourcecontroltest), that in this scenario we would: * trigger a synchronization that starts the resource, and then goes into a loop trying to connecting (KAsync::wait -> singleshot timer) * trigger a shutdown that would probe for the socket, not find it, and thus do nothing. * exit the testfunction, which somehow stops qtimer processing, meaning we are stuck in KAsync::wait. For now this is fixed by simply not probing for the socket.
* FixupChristian Mollekopf2018-07-25
|
* Same fix as last commit.Christian Mollekopf2018-07-25
|
* Fixed crash.Christian Mollekopf2018-07-25
| | | | Could be triggered by running the composerviewtest in kube.
* A faster method for a failing connectionChristian Mollekopf2018-07-24
|
* Wait for long enough so we can time-outChristian Mollekopf2018-07-24
|
* Also serialize single contactsChristian Mollekopf2018-07-24
|
* Use the qdebug serializer to print contactsChristian Mollekopf2018-07-24
|
generated by cgit v1.2.3 (git 2.25.1) at 2025-06-23 19:05:27 +0000