8 files changed, 63 insertions, 11 deletions

diff --git a/common/domain/applicationdomaintype.cpp b/common/domain/applicationdomaintype.cpp
index b0433be..fccf082 100644
--- a/common/domain/applicationdomaintype.cpp
+++ b/common/domain/applicationdomaintype.cpp
@@ -100,6 +100,36 @@ QByteArray ApplicationDomainType::identifier() const
     return mIdentifier;
 }
 
+Entity::~Entity()
+{
+
+}
+
+Event::~Event()
+{
+
+}
+
+Todo::~Todo()
+{
+
+}
+
+Mail::~Mail()
+{
+
+}
+
+Folder::~Folder()
+{
+
+}
+
+SinkResource::~SinkResource()
+{
+
+}
+
 template<>
 QByteArray getTypeName<Event>()
 {
diff --git a/common/domain/applicationdomaintype.h b/common/domain/applicationdomaintype.h
index 63f030c..88f094a 100644
--- a/common/domain/applicationdomaintype.h
+++ b/common/domain/applicationdomaintype.h
@@ -85,31 +85,37 @@ inline bool operator==(const ApplicationDomainType& lhs, const ApplicationDomain
 struct Entity : public ApplicationDomainType {
     typedef QSharedPointer<Entity> Ptr;
     using ApplicationDomainType::ApplicationDomainType;
+    virtual ~Entity();
 };
 
 struct Event : public Entity {
     typedef QSharedPointer<Event> Ptr;
     using Entity::Entity;
+    virtual ~Event();
 };
 
 struct Todo : public Entity {
     typedef QSharedPointer<Todo> Ptr;
     using Entity::Entity;
+    virtual ~Todo();
 };
 
 struct Calendar : public Entity {
     typedef QSharedPointer<Calendar> Ptr;
     using Entity::Entity;
+    virtual ~Calendar();
 };
 
 struct Mail : public Entity {
     typedef QSharedPointer<Mail> Ptr;
     using Entity::Entity;
+    virtual ~Mail();
 };
 
 struct Folder : public Entity {
     typedef QSharedPointer<Folder> Ptr;
     using Entity::Entity;
+    virtual ~Folder();
 };
 
 /**
@@ -121,6 +127,7 @@ struct Folder : public Entity {
 struct SinkResource : public ApplicationDomainType {
     typedef QSharedPointer<SinkResource> Ptr;
     using ApplicationDomainType::ApplicationDomainType;
+    virtual ~SinkResource();
 };
 
 /**
diff --git a/common/genericresource.cpp b/common/genericresource.cpp
index c7326d3..758ea0d 100644
--- a/common/genericresource.cpp
+++ b/common/genericresource.cpp
@@ -197,7 +197,6 @@ private slots:
             default:
                 return KAsync::error<qint64>(-1, "Unhandled command");
         }
-        return KAsync::null<qint64>();
     }
 
     KAsync::Job<qint64, qint64> processQueuedCommand(const QByteArray &data)
diff --git a/common/log.cpp b/common/log.cpp
index 45bbec1..316031d 100644
--- a/common/log.cpp
+++ b/common/log.cpp
@@ -17,7 +17,7 @@ public:
     {
         open(WriteOnly);
     }
-    virtual ~DebugStream(){};
+    virtual ~DebugStream();
 
     bool isSequential() const { return true; }
     qint64 readData(char *, qint64) { return 0; /* eof */ }
@@ -35,6 +35,10 @@ private:
     Q_DISABLE_COPY(DebugStream)
 };
 
+//Virtual method anchor
+DebugStream::~DebugStream()
+{}
+
 class NullStream: public QIODevice
 {
 public:
@@ -43,7 +47,7 @@ public:
     {
         open(WriteOnly);
     }
-    virtual ~NullStream(){};
+    virtual ~NullStream();
 
     bool isSequential() const { return true; }
     qint64 readData(char *, qint64) { return 0; /* eof */ }
@@ -56,6 +60,10 @@ private:
     Q_DISABLE_COPY(NullStream)
 };
 
+//Virtual method anchor
+NullStream::~NullStream()
+{}
+
     /*
      * ANSI color codes:
      * 0: reset colors/style
@@ -175,8 +183,6 @@ QDebug Sink::Log::debugStream(DebugLevel debugLevel, int line, const char* file,
             prefix = "Error:  ";
             prefixColorCode = ANSI_Colors::Red;
             break;
-        default:
-            break;
     };
 
     bool showLocation = false;
diff --git a/common/propertymapper.h b/common/propertymapper.h
index efde72c..94c9224 100644
--- a/common/propertymapper.h
+++ b/common/propertymapper.h
@@ -52,6 +52,8 @@ template<typename BufferType>
 class ReadPropertyMapper
 {
 public:
+    virtual ~ReadPropertyMapper(){};
+
     virtual QVariant getProperty(const QByteArray &key, BufferType const *buffer) const
     {
         if (mReadAccessors.contains(key)) {
@@ -106,6 +108,8 @@ template<typename BufferBuilder>
 class WritePropertyMapper
 {
 public:
+    virtual ~WritePropertyMapper(){};
+
     virtual void setProperty(const QByteArray &key, const QVariant &value, QList<std::function<void(BufferBuilder &)> > &builderCalls, flatbuffers::FlatBufferBuilder &fbb) const
     {
         if (mWriteAccessors.contains(key)) {
diff --git a/common/resourceaccess.cpp b/common/resourceaccess.cpp
index 0c435c9..8296f1d 100644
--- a/common/resourceaccess.cpp
+++ b/common/resourceaccess.cpp
@@ -566,6 +566,9 @@ bool ResourceAccess::processMessageBuffer()
                     }, this);
                 }
                     break;
+                case Sink::Commands::NotificationType::NotificationType_Status:
+                case Sink::Commands::NotificationType::NotificationType_Warning:
+                case Sink::Commands::NotificationType::NotificationType_Progress:
                 default:
                     Warning() << "Received unknown notification: " << buffer->type();
                     break;
diff --git a/common/resultprovider.h b/common/resultprovider.h
index 6958dbf..2d6efbe 100644
--- a/common/resultprovider.h
+++ b/common/resultprovider.h
@@ -27,8 +27,6 @@
 #include "resultset.h"
 #include "log.h"
 
-using namespace async;
-
 namespace Sink {
 
 /**
@@ -47,6 +45,11 @@ public:
 
     }
 
+    virtual ~ResultProviderInterface()
+    {
+
+    }
+
     virtual void add(const T &value) = 0;
     virtual void modify(const T &value) = 0;
     virtual void remove(const T &value) = 0;
@@ -183,7 +186,7 @@ public:
 
     void onDone(const std::function<void()> &callback)
     {
-        mThreadBoundary = QSharedPointer<ThreadBoundary>::create();
+        mThreadBoundary = QSharedPointer<async::ThreadBoundary>::create();
         mOnDoneCallback = callback;
     }
 
@@ -212,7 +215,7 @@ private:
 
     QWeakPointer<ResultEmitter<T> > mResultEmitter;
     std::function<void()> mOnDoneCallback;
-    QSharedPointer<ThreadBoundary> mThreadBoundary;
+    QSharedPointer<async::ThreadBoundary> mThreadBoundary;
     std::function<void(const T &parent)> mFetcher;
 };
 
@@ -327,7 +330,7 @@ private:
     std::function<void(void)> clearHandler;
 
     std::function<void(const DomainType &parent)> mFetcher;
-    ThreadBoundary mThreadBoundary;
+    async::ThreadBoundary mThreadBoundary;
 };
 
 template<class DomainType>
diff --git a/common/storage_lmdb.cpp b/common/storage_lmdb.cpp
index 893c37c..e2c623e 100644
--- a/common/storage_lmdb.cpp
+++ b/common/storage_lmdb.cpp
@@ -443,8 +443,8 @@ Storage::NamedDatabase Storage::Transaction::openDatabase(const QByteArray &db,
     d->implicitCommit = true;
     auto p = new Storage::NamedDatabase::Private(db, allowDuplicates, d->defaultErrorHandler, d->name, d->transaction);
     if (!p->openDatabase(d->requestedRead, errorHandler)) {
-        return Storage::NamedDatabase();
         delete p;
+        return Storage::NamedDatabase();
     }
     return Storage::NamedDatabase(p);
 }