diff options
Diffstat (limited to 'common')
-rw-r--r-- | common/clientapi.cpp | 8 | ||||
-rw-r--r-- | common/clientapi.h | 7 | ||||
-rw-r--r-- | common/pipeline.cpp | 1 |
3 files changed, 2 insertions, 14 deletions
diff --git a/common/clientapi.cpp b/common/clientapi.cpp index 260b6b8..190bb57 100644 --- a/common/clientapi.cpp +++ b/common/clientapi.cpp | |||
@@ -6,14 +6,8 @@ | |||
6 | namespace async | 6 | namespace async |
7 | { | 7 | { |
8 | void run(const std::function<void()> &runner) { | 8 | void run(const std::function<void()> &runner) { |
9 | //TODO use a job that runs in a thread? | ||
9 | QtConcurrent::run(runner); | 10 | QtConcurrent::run(runner); |
10 | |||
11 | // //FIXME we should be using a Job instead of a timer | ||
12 | // auto timer = new QTimer; | ||
13 | // timer->setSingleShot(true); | ||
14 | // QObject::connect(timer, &QTimer::timeout, runner); | ||
15 | // QObject::connect(timer, &QTimer::timeout, timer, &QObject::deleteLater); | ||
16 | // timer->start(0); | ||
17 | }; | 11 | }; |
18 | } // namespace async | 12 | } // namespace async |
19 | 13 | ||
diff --git a/common/clientapi.h b/common/clientapi.h index 71317a1..6b41116 100644 --- a/common/clientapi.h +++ b/common/clientapi.h | |||
@@ -333,11 +333,8 @@ public: | |||
333 | 333 | ||
334 | /** | 334 | /** |
335 | * Facade factory that returns a store facade implementation, by loading a plugin and providing the relevant implementation. | 335 | * Facade factory that returns a store facade implementation, by loading a plugin and providing the relevant implementation. |
336 | * | 336 | * |
337 | * If we were to provide default implementations for certain capabilities. Here would be the place to do so. | 337 | * If we were to provide default implementations for certain capabilities. Here would be the place to do so. |
338 | * | ||
339 | * TODO: pluginmechansims for resources to provide their implementations. | ||
340 | * * We may want a way to recycle facades to avoid recreating socket connections all the time? | ||
341 | */ | 338 | */ |
342 | 339 | ||
343 | class FacadeFactory { | 340 | class FacadeFactory { |
@@ -395,8 +392,6 @@ private: | |||
395 | 392 | ||
396 | /** | 393 | /** |
397 | * Store interface used in the client API. | 394 | * Store interface used in the client API. |
398 | * | ||
399 | * TODO: For testing we need to be able to inject dummy StoreFacades. Should we work with a store instance, or a singleton factory? | ||
400 | */ | 395 | */ |
401 | class Store { | 396 | class Store { |
402 | public: | 397 | public: |
diff --git a/common/pipeline.cpp b/common/pipeline.cpp index f440c6d..7cab8ec 100644 --- a/common/pipeline.cpp +++ b/common/pipeline.cpp | |||
@@ -100,7 +100,6 @@ Async::Job<void> Pipeline::newEntity(void const *command, size_t size) | |||
100 | //TODO toRFC4122 would probably be more efficient, but results in non-printable keys. | 100 | //TODO toRFC4122 would probably be more efficient, but results in non-printable keys. |
101 | const auto key = QUuid::createUuid().toString().toUtf8(); | 101 | const auto key = QUuid::createUuid().toString().toUtf8(); |
102 | 102 | ||
103 | //TODO figure out if we already have created a revision for the message? | ||
104 | const qint64 newRevision = storage().maxRevision() + 1; | 103 | const qint64 newRevision = storage().maxRevision() + 1; |
105 | 104 | ||
106 | { | 105 | { |