require users of a Storage class to state up-front if they are read or readwrite

1 files changed, 12 insertions, 5 deletions

diff --git a/common/storage_lmdb.cpp b/common/storage_lmdb.cpp
index 8e9b05c..7e23fd3 100644
--- a/common/storage_lmdb.cpp
+++ b/common/storage_lmdb.cpp
@@ -14,7 +14,7 @@
 class Storage::Private
 {
 public:
-    Private(const QString &s, const QString &name);
+    Private(const QString &s, const QString &name, AccessMode m);
     ~Private();
 
     QString storageRoot;
@@ -23,14 +23,16 @@ public:
     MDB_dbi dbi;
     MDB_env *env;
     MDB_txn *transaction;
+    AccessMode mode;
     bool readTransaction;
     bool firstOpen;
 };
 
-Storage::Private::Private(const QString &s, const QString &n)
+Storage::Private::Private(const QString &s, const QString &n, AccessMode m)
     : storageRoot(s),
       name(n),
       transaction(0),
+      mode(m),
       readTransaction(false),
       firstOpen(true)
 {
@@ -65,8 +67,8 @@ Storage::Private::~Private()
     mdb_env_close(env);
 }
 
-Storage::Storage(const QString &storageRoot, const QString &name)
-    : d(new Private(storageRoot, name))
+Storage::Storage(const QString &storageRoot, const QString &name, AccessMode mode)
+    : d(new Private(storageRoot, name, mode))
 {
 }
 
@@ -80,13 +82,18 @@ bool Storage::isInTransaction() const
     return d->transaction;
 }
 
-bool Storage::startTransaction(TransactionType type)
+bool Storage::startTransaction(AccessMode type)
 {
     if (!d->env) {
         return false;
     }
 
     bool requestedRead = type == ReadOnly;
+
+    if (d->mode == ReadOnly && !requestedRead) {
+        return false;
+    }
+
     if (d->transaction && (!d->readTransaction || requestedRead)) {
         return true;
     }