diff options
author | Christian Mollekopf <chrigi_1@fastmail.fm> | 2018-07-28 22:29:35 +0200 |
---|---|---|
committer | Christian Mollekopf <chrigi_1@fastmail.fm> | 2018-07-28 22:29:35 +0200 |
commit | a24bf3db83d81d7d7677a1f0f750f208d32998a8 (patch) | |
tree | 0d3fa9da24d706c2e6b03e8bf0fd74a434ae871f /common/storage/entitystore.h | |
parent | 683ee2ec1d198a9f19572e42d78fa0b9939d7f10 (diff) | |
download | sink-a24bf3db83d81d7d7677a1f0f750f208d32998a8.tar.gz sink-a24bf3db83d81d7d7677a1f0f750f208d32998a8.zip |
Avoid unnecessary Identifier conversions in performance ciritical code.
This fixes the performance regressions to a state where we are roughly
at the same performance as pre Identifier (but not any better either).
Diffstat (limited to 'common/storage/entitystore.h')
-rw-r--r-- | common/storage/entitystore.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/common/storage/entitystore.h b/common/storage/entitystore.h index 619b884..7979798 100644 --- a/common/storage/entitystore.h +++ b/common/storage/entitystore.h | |||
@@ -57,8 +57,8 @@ public: | |||
57 | void abortTransaction(); | 57 | void abortTransaction(); |
58 | bool hasTransaction() const; | 58 | bool hasTransaction() const; |
59 | 59 | ||
60 | QVector<QByteArray> fullScan(const QByteArray &type); | 60 | QVector<Sink::Storage::Identifier> fullScan(const QByteArray &type); |
61 | QVector<QByteArray> indexLookup(const QByteArray &type, const QueryBase &query, QSet<QByteArrayList> &appliedFilters, QByteArray &appliedSorting); | 61 | QVector<Sink::Storage::Identifier> indexLookup(const QByteArray &type, const QueryBase &query, QSet<QByteArrayList> &appliedFilters, QByteArray &appliedSorting); |
62 | QVector<Sink::Storage::Identifier> indexLookup(const QByteArray &type, const QByteArray &property, const QVariant &value); | 62 | QVector<Sink::Storage::Identifier> indexLookup(const QByteArray &type, const QByteArray &property, const QVariant &value); |
63 | void indexLookup(const QByteArray &type, const QByteArray &property, const QVariant &value, const std::function<void(const QByteArray &uid)> &callback); | 63 | void indexLookup(const QByteArray &type, const QByteArray &property, const QVariant &value, const std::function<void(const QByteArray &uid)> &callback); |
64 | template<typename EntityType, typename PropertyType> | 64 | template<typename EntityType, typename PropertyType> |