summaryrefslogtreecommitdiffstats
path: root/common/genericresource.cpp
diff options
context:
space:
mode:
authorChristian Mollekopf <chrigi_1@fastmail.fm>2015-10-28 16:39:16 +0100
committerChristian Mollekopf <chrigi_1@fastmail.fm>2015-10-28 16:39:16 +0100
commit129333371d28c06d85f75ca579ce17798e615e84 (patch)
tree2ae01db9d26f6f72a74fa77e6937e03304e81a2c /common/genericresource.cpp
parent20f049b65c4bd8c3d0c16bbf398641675648a93f (diff)
downloadsink-129333371d28c06d85f75ca579ce17798e615e84.tar.gz
sink-129333371d28c06d85f75ca579ce17798e615e84.zip
Made pipeline preprocessing synchronous.
Instead of having the asynchronous preprocessor concept with different pipelines for new/modify/delete we have a single pipeline with synchronous preprocessors that act upon new/modify/delete. This keeps the code simpler due to lack of asynchronity and keeps the new/modify/delete operations together (which at least for the indexing makes a lot of sense). Not supporting asynchronity is ok because the tasks done in preprocessing are not cpu intensive (if they were we had a problem since they are directly involved in the round-trip time), and the main cost comes from i/o, meaning we don't gain much by doing multithreading. Costly tasks (such as full-text indexing) should rather be implemented as post-processing, since that doesn't increase the round-trip time directly, and eventually consistent is typically good enough for that.
Diffstat (limited to 'common/genericresource.cpp')
-rw-r--r--common/genericresource.cpp10
1 files changed, 6 insertions, 4 deletions
diff --git a/common/genericresource.cpp b/common/genericresource.cpp
index dcae43d..ec68f33 100644
--- a/common/genericresource.cpp
+++ b/common/genericresource.cpp
@@ -285,10 +285,12 @@ GenericResource::~GenericResource()
285 delete mSourceChangeReplay; 285 delete mSourceChangeReplay;
286} 286}
287 287
288// void GenericResource::revisionChanged() 288void GenericResource::removeFromDisk(const QByteArray &instanceIdentifier)
289// { 289{
290// //TODO replay revision 290 Akonadi2::Storage(Akonadi2::storageLocation(), instanceIdentifier, Akonadi2::Storage::ReadWrite).removeFromDisk();
291// } 291 Akonadi2::Storage(Akonadi2::storageLocation(), instanceIdentifier + ".userqueue", Akonadi2::Storage::ReadWrite).removeFromDisk();
292 Akonadi2::Storage(Akonadi2::storageLocation(), instanceIdentifier + ".synchronizerqueue", Akonadi2::Storage::ReadWrite).removeFromDisk();
293}
292 294
293void GenericResource::onProcessorError(int errorCode, const QString &errorMessage) 295void GenericResource::onProcessorError(int errorCode, const QString &errorMessage)
294{ 296{