Copy the entity when we return it.

Otherwise we easily end up copying it and then have an entity that
points into nowhere. Callback -> no copy, no callback -> copy.

1 files changed, 11 insertions, 0 deletions

diff --git a/common/entitybuffer.h b/common/entitybuffer.h
index 4162605..d73a138 100644
--- a/common/entitybuffer.h
+++ b/common/entitybuffer.h
@@ -12,7 +12,18 @@ struct Entity;
 class SINK_EXPORT EntityBuffer
 {
 public:
+    /**
+     * Creates an entity buffer from @param dataValue.
+     *
+     * Note that @param dataValue will need to remain valid and the data is not copied.
+     */
     EntityBuffer(const void *dataValue, int size);
+
+    /**
+     * Creates an entity buffer from @param data.
+     *
+     * Note that @param data will need to remain valid and the data is not copied.
+     */
     EntityBuffer(const QByteArray &data);
     const uint8_t *resourceBuffer();
     const uint8_t *metadataBuffer();