summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristian Mollekopf <chrigi_1@fastmail.fm>2016-11-27 10:50:41 +0100
committerChristian Mollekopf <chrigi_1@fastmail.fm>2016-11-27 10:50:41 +0100
commit9fe1d50d7ace50f1f7efc66412dff006f20a2062 (patch)
treef0f11edfe9e4542e5cce229bc156306556d8fbf7
parentdf99cc0a8fc96e6584d71a6fe03cad2b321118cb (diff)
downloadsink-9fe1d50d7ace50f1f7efc66412dff006f20a2062.tar.gz
sink-9fe1d50d7ace50f1f7efc66412dff006f20a2062.zip
Cleanup
-rw-r--r--common/genericresource.h2
-rw-r--r--examples/imapresource/imapresource.cpp11
-rw-r--r--examples/imapresource/imapresource.h3
-rw-r--r--examples/maildirresource/maildirresource.cpp11
-rw-r--r--examples/maildirresource/maildirresource.h3
-rw-r--r--examples/mailtransportresource/mailtransportresource.cpp5
-rw-r--r--examples/mailtransportresource/mailtransportresource.h2
7 files changed, 10 insertions, 27 deletions
diff --git a/common/genericresource.h b/common/genericresource.h
index 9447c8b..a3a58b9 100644
--- a/common/genericresource.h
+++ b/common/genericresource.h
@@ -43,7 +43,7 @@ class SINK_EXPORT GenericResource : public Resource
43protected: 43protected:
44 SINK_DEBUG_AREA("resource") 44 SINK_DEBUG_AREA("resource")
45public: 45public:
46 GenericResource(const Sink::ResourceContext &context, const QSharedPointer<Pipeline> &pipeline); 46 GenericResource(const Sink::ResourceContext &context, const QSharedPointer<Pipeline> &pipeline = QSharedPointer<Pipeline>());
47 virtual ~GenericResource(); 47 virtual ~GenericResource();
48 48
49 virtual void processCommand(int commandId, const QByteArray &data) Q_DECL_OVERRIDE; 49 virtual void processCommand(int commandId, const QByteArray &data) Q_DECL_OVERRIDE;
diff --git a/examples/imapresource/imapresource.cpp b/examples/imapresource/imapresource.cpp
index 8fc7702..2aa5a2c 100644
--- a/examples/imapresource/imapresource.cpp
+++ b/examples/imapresource/imapresource.cpp
@@ -20,7 +20,6 @@
20#include "imapresource.h" 20#include "imapresource.h"
21 21
22#include "facade.h" 22#include "facade.h"
23#include "pipeline.h"
24#include "resourceconfig.h" 23#include "resourceconfig.h"
25#include "commands.h" 24#include "commands.h"
26#include "index.h" 25#include "index.h"
@@ -554,8 +553,8 @@ public:
554 QByteArray mResourceInstanceIdentifier; 553 QByteArray mResourceInstanceIdentifier;
555}; 554};
556 555
557ImapResource::ImapResource(const ResourceContext &resourceContext, const QSharedPointer<Sink::Pipeline> &pipeline) 556ImapResource::ImapResource(const ResourceContext &resourceContext)
558 : Sink::GenericResource(resourceContext, pipeline) 557 : Sink::GenericResource(resourceContext)
559{ 558{
560 auto config = ResourceConfig::getConfiguration(resourceContext.instanceId()); 559 auto config = ResourceConfig::getConfiguration(resourceContext.instanceId());
561 mServer = config.value("server").toString(); 560 mServer = config.value("server").toString();
@@ -583,12 +582,6 @@ ImapResource::ImapResource(const ResourceContext &resourceContext, const QShared
583 setupPreprocessors(ENTITY_TYPE_FOLDER, QVector<Sink::Preprocessor*>()); 582 setupPreprocessors(ENTITY_TYPE_FOLDER, QVector<Sink::Preprocessor*>());
584} 583}
585 584
586void ImapResource::removeFromDisk(const QByteArray &instanceIdentifier)
587{
588 GenericResource::removeFromDisk(instanceIdentifier);
589 Sink::Storage::DataStore(Sink::storageLocation(), instanceIdentifier + ".synchronization", Sink::Storage::DataStore::ReadWrite).removeFromDisk();
590}
591
592KAsync::Job<void> ImapResource::inspect(int inspectionType, const QByteArray &inspectionId, const QByteArray &domainType, const QByteArray &entityId, const QByteArray &property, const QVariant &expectedValue) 585KAsync::Job<void> ImapResource::inspect(int inspectionType, const QByteArray &inspectionId, const QByteArray &domainType, const QByteArray &entityId, const QByteArray &property, const QVariant &expectedValue)
593{ 586{
594 auto synchronizationStore = QSharedPointer<Sink::Storage::DataStore>::create(Sink::storageLocation(), mResourceContext.instanceId() + ".synchronization", Sink::Storage::DataStore::ReadOnly); 587 auto synchronizationStore = QSharedPointer<Sink::Storage::DataStore>::create(Sink::storageLocation(), mResourceContext.instanceId() + ".synchronization", Sink::Storage::DataStore::ReadOnly);
diff --git a/examples/imapresource/imapresource.h b/examples/imapresource/imapresource.h
index 216c6c5..d345d64 100644
--- a/examples/imapresource/imapresource.h
+++ b/examples/imapresource/imapresource.h
@@ -39,9 +39,8 @@ struct Folder;
39class ImapResource : public Sink::GenericResource 39class ImapResource : public Sink::GenericResource
40{ 40{
41public: 41public:
42 ImapResource(const Sink::ResourceContext &resourceContext, const QSharedPointer<Sink::Pipeline> &pipeline = QSharedPointer<Sink::Pipeline>()); 42 ImapResource(const Sink::ResourceContext &resourceContext);
43 KAsync::Job<void> inspect(int inspectionType, const QByteArray &inspectionId, const QByteArray &domainType, const QByteArray &entityId, const QByteArray &property, const QVariant &expectedValue) Q_DECL_OVERRIDE; 43 KAsync::Job<void> inspect(int inspectionType, const QByteArray &inspectionId, const QByteArray &domainType, const QByteArray &entityId, const QByteArray &property, const QVariant &expectedValue) Q_DECL_OVERRIDE;
44 static void removeFromDisk(const QByteArray &instanceIdentifier);
45 44
46private: 45private:
47 QString mServer; 46 QString mServer;
diff --git a/examples/maildirresource/maildirresource.cpp b/examples/maildirresource/maildirresource.cpp
index fed18c4..ee84bde 100644
--- a/examples/maildirresource/maildirresource.cpp
+++ b/examples/maildirresource/maildirresource.cpp
@@ -20,7 +20,6 @@
20#include "maildirresource.h" 20#include "maildirresource.h"
21 21
22#include "facade.h" 22#include "facade.h"
23#include "pipeline.h"
24#include "resourceconfig.h" 23#include "resourceconfig.h"
25#include "index.h" 24#include "index.h"
26#include "log.h" 25#include "log.h"
@@ -427,8 +426,8 @@ public:
427}; 426};
428 427
429 428
430MaildirResource::MaildirResource(const Sink::ResourceContext &resourceContext, const QSharedPointer<Sink::Pipeline> &pipeline) 429MaildirResource::MaildirResource(const Sink::ResourceContext &resourceContext)
431 : Sink::GenericResource(resourceContext, pipeline) 430 : Sink::GenericResource(resourceContext)
432{ 431{
433 auto config = ResourceConfig::getConfiguration(resourceContext.instanceId()); 432 auto config = ResourceConfig::getConfiguration(resourceContext.instanceId());
434 mMaildirPath = QDir::cleanPath(QDir::fromNativeSeparators(config.value("path").toString())); 433 mMaildirPath = QDir::cleanPath(QDir::fromNativeSeparators(config.value("path").toString()));
@@ -459,12 +458,6 @@ MaildirResource::MaildirResource(const Sink::ResourceContext &resourceContext, c
459 synchronizer->commit(); 458 synchronizer->commit();
460} 459}
461 460
462void MaildirResource::removeFromDisk(const QByteArray &instanceIdentifier)
463{
464 GenericResource::removeFromDisk(instanceIdentifier);
465 Sink::Storage::DataStore(Sink::storageLocation(), instanceIdentifier + ".synchronization", Sink::Storage::DataStore::ReadWrite).removeFromDisk();
466}
467
468KAsync::Job<void> MaildirResource::inspect(int inspectionType, const QByteArray &inspectionId, const QByteArray &domainType, const QByteArray &entityId, const QByteArray &property, const QVariant &expectedValue) 461KAsync::Job<void> MaildirResource::inspect(int inspectionType, const QByteArray &inspectionId, const QByteArray &domainType, const QByteArray &entityId, const QByteArray &property, const QVariant &expectedValue)
469{ 462{
470 auto synchronizationStore = QSharedPointer<Sink::Storage::DataStore>::create(Sink::storageLocation(), mResourceContext.instanceId() + ".synchronization", Sink::Storage::DataStore::ReadOnly); 463 auto synchronizationStore = QSharedPointer<Sink::Storage::DataStore>::create(Sink::storageLocation(), mResourceContext.instanceId() + ".synchronization", Sink::Storage::DataStore::ReadOnly);
diff --git a/examples/maildirresource/maildirresource.h b/examples/maildirresource/maildirresource.h
index 2d1090b..4eb2042 100644
--- a/examples/maildirresource/maildirresource.h
+++ b/examples/maildirresource/maildirresource.h
@@ -42,9 +42,8 @@ class MaildirFolderAdaptorFactory;
42class MaildirResource : public Sink::GenericResource 42class MaildirResource : public Sink::GenericResource
43{ 43{
44public: 44public:
45 MaildirResource(const Sink::ResourceContext &resourceContext, const QSharedPointer<Sink::Pipeline> &pipeline = QSharedPointer<Sink::Pipeline>()); 45 MaildirResource(const Sink::ResourceContext &resourceContext);
46 KAsync::Job<void> inspect(int inspectionType, const QByteArray &inspectionId, const QByteArray &domainType, const QByteArray &entityId, const QByteArray &property, const QVariant &expectedValue) Q_DECL_OVERRIDE; 46 KAsync::Job<void> inspect(int inspectionType, const QByteArray &inspectionId, const QByteArray &domainType, const QByteArray &entityId, const QByteArray &property, const QVariant &expectedValue) Q_DECL_OVERRIDE;
47 static void removeFromDisk(const QByteArray &instanceIdentifier);
48private: 47private:
49 48
50 QStringList listAvailableFolders(); 49 QStringList listAvailableFolders();
diff --git a/examples/mailtransportresource/mailtransportresource.cpp b/examples/mailtransportresource/mailtransportresource.cpp
index 0688af6..c135de9 100644
--- a/examples/mailtransportresource/mailtransportresource.cpp
+++ b/examples/mailtransportresource/mailtransportresource.cpp
@@ -34,7 +34,6 @@
34#include <synchronizer.h> 34#include <synchronizer.h>
35#include <log.h> 35#include <log.h>
36#include <resourceconfig.h> 36#include <resourceconfig.h>
37#include <pipeline.h>
38#include <mailpreprocessor.h> 37#include <mailpreprocessor.h>
39#include <adaptorfactoryregistry.h> 38#include <adaptorfactoryregistry.h>
40 39
@@ -125,8 +124,8 @@ public:
125 MailtransportResource::Settings mSettings; 124 MailtransportResource::Settings mSettings;
126}; 125};
127 126
128MailtransportResource::MailtransportResource(const Sink::ResourceContext &resourceContext, const QSharedPointer<Sink::Pipeline> &pipeline) 127MailtransportResource::MailtransportResource(const Sink::ResourceContext &resourceContext)
129 : Sink::GenericResource(resourceContext, pipeline) 128 : Sink::GenericResource(resourceContext)
130{ 129{
131 auto config = ResourceConfig::getConfiguration(resourceContext.instanceId()); 130 auto config = ResourceConfig::getConfiguration(resourceContext.instanceId());
132 mSettings = {config.value("server").toString(), 131 mSettings = {config.value("server").toString(),
diff --git a/examples/mailtransportresource/mailtransportresource.h b/examples/mailtransportresource/mailtransportresource.h
index a6f1167..95a9cd7 100644
--- a/examples/mailtransportresource/mailtransportresource.h
+++ b/examples/mailtransportresource/mailtransportresource.h
@@ -25,7 +25,7 @@
25class MailtransportResource : public Sink::GenericResource 25class MailtransportResource : public Sink::GenericResource
26{ 26{
27public: 27public:
28 MailtransportResource(const Sink::ResourceContext &resourceContext, const QSharedPointer<Sink::Pipeline> &pipeline = QSharedPointer<Sink::Pipeline>()); 28 MailtransportResource(const Sink::ResourceContext &resourceContext);
29 KAsync::Job<void> inspect(int inspectionType, const QByteArray &inspectionId, const QByteArray &domainType, const QByteArray &entityId, const QByteArray &property, const QVariant &expectedValue) Q_DECL_OVERRIDE; 29 KAsync::Job<void> inspect(int inspectionType, const QByteArray &inspectionId, const QByteArray &domainType, const QByteArray &entityId, const QByteArray &property, const QVariant &expectedValue) Q_DECL_OVERRIDE;
30 static void removeFromDisk(const QByteArray &instanceIdentifier); 30 static void removeFromDisk(const QByteArray &instanceIdentifier);
31 31