From 51fbcca97ef9058cdb75c52ac77bdc728a296e4a Mon Sep 17 00:00:00 2001 From: Heiko Becker Date: Fri, 2 Jun 2017 21:35:37 +0200 Subject: Use imported targets instead of qt5_use_modules From Qt's documentation: "This macro is obsolete. Use target_link_libraries with IMPORTED targets instead." It's only recommended with cmake >=2.8.9 & < 2.8.12. Kube already requires cmake 3.0. One advantage of using the imported targets is, that cmake complains if a target isn't found before it's used, like Qt5Concurrent missing from the find_package_call here. Reviewers: #kube, cmollekopf Reviewed By: #kube, cmollekopf Subscribers: #kube Differential Revision: https://phabricator.kde.org/D6362 --- accounts/imap/tests/CMakeLists.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'accounts/imap/tests') diff --git a/accounts/imap/tests/CMakeLists.txt b/accounts/imap/tests/CMakeLists.txt index 9c914370..82d6059c 100644 --- a/accounts/imap/tests/CMakeLists.txt +++ b/accounts/imap/tests/CMakeLists.txt @@ -2,5 +2,10 @@ include_directories(../) cmake_policy(SET CMP0063 NEW) add_executable(imapsettingstest settingstest.cpp) add_test(imapsettingstest settingstest) -qt5_use_modules(imapsettingstest Core Test Concurrent) -target_link_libraries(imapsettingstest sink imapaccount_static) +target_link_libraries(imapsettingstest + sink + imapaccount_static + Qt5::Core + Qt5::Concurrent + Qt5::Test +) -- cgit v1.2.3