| Commit message (Collapse) | Author | Age |
| |
|
|
|
|
| |
It's widely supported by now, so let's just use it.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
There are many things going on here (perhaps a bit much for a single patch):
- When an attachment is of mime type "application/pgp-keys", a button is added to import the key to GPG
- When sending a mail and crypto is enabled (encryption, signing or both), the public key of the first private key found is sent as an un-encrypted attachment (T6994)
- The `mailcrypto.{h,cpp}` was, for the most part, rewritten
- Introduction of the expected monad, inspired by what was proposed for C++ [here](https://isocpp.org/files/papers/n4015.pdf), but not at all a strict implementation of this specification. We may want to add some more features of this standard later.
The rationale for some of the choices:
- I found mailcrypto a bit hard to edit to add new features, and a great part was commented code to prepare for the support the SMIME crypto format, which would (in my current knowledge) not be used for sending emails.
- One thing I found that may be missing in the code base was a standardized way of handling errors in C++ code. Since exceptions are disabled I think that the functional way is the way to go. After some research I found the Expected monad / tagged union / sum type, which seemed to suit the problem particularly well.
In the long run, I hope we would move the entire code base to use `Expected` to indicate if a function might fail.
Of course every choice made here is to be considered as a proposition for doing things / RFC, critics wholeheartedly accepted.
Reviewers: cmollekopf
Tags: #kube
Maniphest Tasks: T6994, T8147, T6995
Differential Revision: https://phabricator.kde.org/D11158
|
|
|
|
|
| |
The new messages available info is also irrelevant for the current
folder.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Some notes:
- What we do is: if the mail is encrypted, decrypt it and copy its content into a new message (with plaintext, html and attachments, if any), and use this message as attachment for forwarding
- The `isEncrypted` function from KMime doesn't seem to detect every kind of encrypted mails. AFAIK this structure is not detected:
- `multipart/mixed`
- `text/plain`
- `application/pgp-encrypted` (attachement, named "ATT00001")
- `application/octet-stream` (attachment named "encrypted.asc")
Reviewers: cmollekopf
Tags: PHID-PROJ-6npnfcmppynqynn7slmv
Maniphest Tasks: T8112, T7024
Differential Revision: https://phabricator.kde.org/D10966
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
This reverts commit f28ec43dca5b2915deb69d54fb942ddf1303f48c.
That was pushed by accident.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Some notes:
- What we do is: if the mail is encrypted, decrypt it and copy its content into a new message (with plaintext, html and attachments, if any), and use this message as attachment for forwarding
- The `isEncrypted` function from KMime doesn't seem to detect every kind of encrypted mails. AFAIK this structure is not detected:
- `multipart/mixed`
- `text/plain`
- `application/pgp-encrypted` (attachement, named "ATT00001")
- `application/octet-stream` (attachment named "encrypted.asc")
Reviewers: cmollekopf
Tags: PHID-PROJ-6npnfcmppynqynn7slmv
Maniphest Tasks: T8112, T7024
Differential Revision: https://phabricator.kde.org/D10966
|
|
|
|
|
| |
We listen for new mail notifications, and highlight the folder
accordingly.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
setProperty doesn't work anymore for some reason, so we use a regular
Q_PROPERTY.
We have to explicitly reference the composerController variable,
otherwise cc/bcc refernces don't work.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Some notes:
- From what I've seen, the `.travis.yml` file (and by extension the `.travis` dir) needs to be on every branch we want Travis to build continuously + the main (master) branch for detection
- Since every branch continuously tested must have the `.travis.yml` file, that allows for feature specific dependency version pinning
- The Sink dependency follows the "develop" branch, but Travis will not detect new commits in Sink, so to update, either trigger a build manually on Travis-CI, or make a new commit in Kube
- Unit Tests are disabled for now
Reviewers: cmollekopf
Tags: #kube
Differential Revision: https://phabricator.kde.org/D10891
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
- Add a test view for the log view
- Allow passing the `entities` part of Sink messages
- That allowed getting information about which mail could not be sent in sink transmission errors
Reviewers: cmollekopf
Reviewed By: cmollekopf
Differential Revision: https://phabricator.kde.org/D10861
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Tools:
- [EditorConfig](http://editorconfig.org/)
- [Clang Format](https://clang.llvm.org/docs/ClangFormat.html)
Code style:
- ClangFormat taken from Sink's configuration with small modifications:
- max width set to 100 characters
- do not pack arguments and initializer list elements
- no space inside brace lists
- EditorConfig: UNIX style text files, 4 spaces for indentation
Reviewers: cmollekopf
Reviewed By: cmollekopf
Tags: #kube
Differential Revision: https://phabricator.kde.org/D10740
|
| |
|
|
|
|
| |
...via syntax highligher or search api.
|
|
|
|
|
|
|
|
|
| |
...and cleanup the sizes of the text/html part a bit.
Html content with a <pre> tag, such as inserted by an apple mail reply,
is not reflowed in the TextEdit (it is in the WebEngineView).
And that causes the text edit to run off the side of the conversation
view.
|
|
|
|
| |
This fixes marking partially unread threads as read.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Implement attachment-based forwarding.
Some notes:
- `loadAsDraft` was removed in favor of new enum `loadType` in QML, and callback based generic programming in C++
Reviewers: cmollekopf
Tags: #kube
Maniphest Tasks: T7024
Differential Revision: https://phabricator.kde.org/D10676
|