diff options
author | Christian Mollekopf <chrigi_1@fastmail.fm> | 2018-02-26 17:28:08 +0100 |
---|---|---|
committer | Christian Mollekopf <chrigi_1@fastmail.fm> | 2018-02-26 17:29:58 +0100 |
commit | 5beca0c6212af94a06c55c85b46cf6a884f8ca75 (patch) | |
tree | 8e260c9f2aff9dfd9d212d83f4fd9ccb31e8fda0 /framework | |
parent | 0d13d2fe1097db160c8b31cb1137846a97e3b362 (diff) | |
download | kube-5beca0c6212af94a06c55c85b46cf6a884f8ca75.tar.gz kube-5beca0c6212af94a06c55c85b46cf6a884f8ca75.zip |
Using setContent instead of setBody will lead to a trailing newline
Diffstat (limited to 'framework')
3 files changed, 7 insertions, 8 deletions
diff --git a/framework/src/domain/mime/mimetreeparser/messagepart.cpp b/framework/src/domain/mime/mimetreeparser/messagepart.cpp index 5f14b7bd..a86969a3 100644 --- a/framework/src/domain/mime/mimetreeparser/messagepart.cpp +++ b/framework/src/domain/mime/mimetreeparser/messagepart.cpp | |||
@@ -893,7 +893,7 @@ void SignedMessagePart::setVerificationResult(const GpgME::VerificationResult &r | |||
893 | } | 893 | } |
894 | if (!mVerifiedText.isEmpty() && parseText) { | 894 | if (!mVerifiedText.isEmpty() && parseText) { |
895 | auto tempNode = new KMime::Content(); | 895 | auto tempNode = new KMime::Content(); |
896 | tempNode->setContent(KMime::CRLFtoLF(mVerifiedText.constData())); | 896 | tempNode->setBody(mVerifiedText); |
897 | tempNode->parse(); | 897 | tempNode->parse(); |
898 | bindLifetime(tempNode); | 898 | bindLifetime(tempNode); |
899 | 899 | ||
diff --git a/framework/src/domain/mime/mimetreeparser/tests/gpgerrortest.cpp b/framework/src/domain/mime/mimetreeparser/tests/gpgerrortest.cpp index 4c03bbe2..32bffeb5 100644 --- a/framework/src/domain/mime/mimetreeparser/tests/gpgerrortest.cpp +++ b/framework/src/domain/mime/mimetreeparser/tests/gpgerrortest.cpp | |||
@@ -68,13 +68,14 @@ private slots: | |||
68 | otp.print(); | 68 | otp.print(); |
69 | auto partList = otp.collectContentParts(); | 69 | auto partList = otp.collectContentParts(); |
70 | QCOMPARE(partList.size(), 1); | 70 | QCOMPARE(partList.size(), 1); |
71 | auto part = partList[0].dynamicCast<MimeTreeParser::SignedMessagePart>(); | 71 | auto part = partList[0]; |
72 | QVERIFY(bool(part)); | 72 | QVERIFY(bool(part)); |
73 | 73 | ||
74 | qWarning() << part->metaObject()->className() << part->text() << part->partMetaData()->status; | 74 | qWarning() << part->metaObject()->className() << part->text() << part->partMetaData()->status; |
75 | QVERIFY(part->text().startsWith("asdasd")); | 75 | QVERIFY(part->text().startsWith("asdasd")); |
76 | QCOMPARE(part->encryptions().size(), 1); | 76 | QCOMPARE(part->encryptions().size(), 1); |
77 | // auto enc = part->encryptions()[0]; | 77 | auto enc = part->encryptions()[0]; |
78 | QCOMPARE(enc->error(), MimeTreeParser::MessagePart::NoError); | ||
78 | // QCOMPARE(enc->errorType(), Encryption::NoError); | 79 | // QCOMPARE(enc->errorType(), Encryption::NoError); |
79 | // QCOMPARE(enc->errorString(), QString()); | 80 | // QCOMPARE(enc->errorString(), QString()); |
80 | // QCOMPARE((int) enc->recipients().size(), 2); | 81 | // QCOMPARE((int) enc->recipients().size(), 2); |
diff --git a/framework/src/domain/mime/mimetreeparser/tests/interfacetest.cpp b/framework/src/domain/mime/mimetreeparser/tests/interfacetest.cpp index a8e608ba..69509715 100644 --- a/framework/src/domain/mime/mimetreeparser/tests/interfacetest.cpp +++ b/framework/src/domain/mime/mimetreeparser/tests/interfacetest.cpp | |||
@@ -155,12 +155,10 @@ private slots: | |||
155 | auto part = partList[0].dynamicCast<MimeTreeParser::MessagePart>(); | 155 | auto part = partList[0].dynamicCast<MimeTreeParser::MessagePart>(); |
156 | QVERIFY(bool(part)); | 156 | QVERIFY(bool(part)); |
157 | QCOMPARE(part->charset(), QStringLiteral("ISO-8859-1").toLocal8Bit()); | 157 | QCOMPARE(part->charset(), QStringLiteral("ISO-8859-1").toLocal8Bit()); |
158 | QEXPECT_FAIL("", "gpgpme break encoding it seems, or the original file is broken", Continue); | 158 | QCOMPARE(part->text(), QString::fromUtf8("asdasd asd asd asdf sadf sdaf sadf öäü")); |
159 | QCOMPARE(part->text(), QString::fromUtf8("asdasd asd asd asdf sadf sdaf sadf äöü")); | ||
160 | 159 | ||
161 | //FIXME | 160 | QCOMPARE(part->encryptions().size(), 1); |
162 | // QCOMPARE(part->encryptions().size(), 1); | 161 | QCOMPARE(part->signatures().size(), 1); |
163 | // QCOMPARE(part->signatures().size(), 1); | ||
164 | QCOMPARE(otp.collectAttachmentParts().size(), 0); | 162 | QCOMPARE(otp.collectAttachmentParts().size(), 0); |
165 | } | 163 | } |
166 | 164 | ||