diff options
author | Christian Mollekopf <chrigi_1@fastmail.fm> | 2018-02-23 09:32:04 +0100 |
---|---|---|
committer | Christian Mollekopf <chrigi_1@fastmail.fm> | 2018-02-23 09:52:02 +0100 |
commit | 46486a878310df55b686b8fbc2b6aaf35d613da7 (patch) | |
tree | c4032ae842c20cb73e0dc6ce3b039230ededaf70 | |
parent | a9b086954e17d6f2d64ac94b225577cb0e416f4f (diff) | |
download | kube-46486a878310df55b686b8fbc2b6aaf35d613da7.tar.gz kube-46486a878310df55b686b8fbc2b6aaf35d613da7.zip |
Demonstrate reflow problems
...and cleanup the sizes of the text/html part a bit.
Html content with a <pre> tag, such as inserted by an apple mail reply,
is not reflowed in the TextEdit (it is in the WebEngineView).
And that causes the text edit to run off the side of the conversation
view.
-rw-r--r-- | components/mailviewer/qml/HtmlContent.qml | 2 | ||||
-rw-r--r-- | components/mailviewer/qml/TextContent.qml | 2 | ||||
-rw-r--r-- | tests/teststore.cpp | 2 | ||||
-rw-r--r-- | views/conversation/main.qml | 17 |
4 files changed, 19 insertions, 4 deletions
diff --git a/components/mailviewer/qml/HtmlContent.qml b/components/mailviewer/qml/HtmlContent.qml index 3ac1bb38..f0249a01 100644 --- a/components/mailviewer/qml/HtmlContent.qml +++ b/components/mailviewer/qml/HtmlContent.qml | |||
@@ -28,8 +28,6 @@ Item { | |||
28 | //We have to give it a minimum size so the html content starts to expand | 28 | //We have to give it a minimum size so the html content starts to expand |
29 | property int contentHeight: 10; | 29 | property int contentHeight: 10; |
30 | 30 | ||
31 | height: contentHeight | ||
32 | width: partColumn.width | ||
33 | 31 | ||
34 | WebEngineView { | 32 | WebEngineView { |
35 | id: htmlView | 33 | id: htmlView |
diff --git a/components/mailviewer/qml/TextContent.qml b/components/mailviewer/qml/TextContent.qml index 5d8dbc90..316786ef 100644 --- a/components/mailviewer/qml/TextContent.qml +++ b/components/mailviewer/qml/TextContent.qml | |||
@@ -27,7 +27,7 @@ Item { | |||
27 | property bool embedded: true | 27 | property bool embedded: true |
28 | property string type | 28 | property string type |
29 | 29 | ||
30 | height: textEdit.height | 30 | property int contentHeight: textEdit.height |
31 | 31 | ||
32 | TextEdit { | 32 | TextEdit { |
33 | id: textEdit | 33 | id: textEdit |
diff --git a/tests/teststore.cpp b/tests/teststore.cpp index 6dbe5622..e5a3ea88 100644 --- a/tests/teststore.cpp +++ b/tests/teststore.cpp | |||
@@ -73,7 +73,7 @@ static void createMail(const QVariantMap &object, const QByteArray &folder = {}) | |||
73 | mb, | 73 | mb, |
74 | object["subject"].toString(), | 74 | object["subject"].toString(), |
75 | object["body"].toString(), | 75 | object["body"].toString(), |
76 | {}, | 76 | object["bodyIsHtml"].toBool(), |
77 | {}, | 77 | {}, |
78 | {}, | 78 | {}, |
79 | {}); | 79 | {}); |
diff --git a/views/conversation/main.qml b/views/conversation/main.qml index 9e17a0b6..686aeecb 100644 --- a/views/conversation/main.qml +++ b/views/conversation/main.qml | |||
@@ -100,6 +100,23 @@ ApplicationWindow { | |||
100 | to: ["öüä@example.org"], | 100 | to: ["öüä@example.org"], |
101 | unread: true | 101 | unread: true |
102 | }, | 102 | }, |
103 | { | ||
104 | resource: "resource1", | ||
105 | date: "2017-07-20T17:47:29", | ||
106 | subject: "PlainLongLine", | ||
107 | body: "Hi Mélanie,\n\nI'm sorry to start this on such late notice, but we'd like to get Foo and boo to woo next week, because the following weeks are unfortunately not possible for us.\n", | ||
108 | to: ["to@example.org"], | ||
109 | unread: true | ||
110 | }, | ||
111 | { | ||
112 | resource: "resource1", | ||
113 | date: "2017-07-20T17:46:29", | ||
114 | subject: "HTMLLongLine", | ||
115 | body: "<pre>Hi Mélanie,\n\nI'm sorry to start this on such late notice, but we'd like to get Foo and boo to woo next week, because the following weeks are unfortunately not possible for us.\n<pre>", | ||
116 | bodyIsHtml: true, | ||
117 | to: ["to@example.org"], | ||
118 | unread: true | ||
119 | }, | ||
103 | ] | 120 | ] |
104 | }], | 121 | }], |
105 | } | 122 | } |